mosaicstack/stack
25
0
Fork 1
Code Issues 408 Pull Requests 13 Actions Packages Projects Releases 15 Wiki Activity

Case 2 C2-13a unit render and host precheck (#416) #1732

New Issue
Closed
opened 2026-10-20 21:32:54 +00:00 by jarvis · 4 comments
jarvis commented 2026-10-20 21:32:54 +00:00
Contributor
Copy Link
Copy Source

Brief: docs/plans/2026-10-20_case2-rows.md section "C2-13a unit render and host precheck" (refactor 5b8def2f1, from Gosalyn eac92d956, design r11 approved in webby-0038). Owner gosalyn, reviewer webby, gate owner Sage. No parent. Row 195 (Case 1 install on .53) chains on this row's candidate (Q177). C2-13b (row 226) comes after it. Case 2 is Vikunja P19 #416, due 2026-10-27.

Brief: docs/plans/2026-10-20_case2-rows.md section "C2-13a unit render and host precheck" (refactor 5b8def2f1, from Gosalyn eac92d956, design r11 approved in webby-0038). Owner gosalyn, reviewer webby, gate owner Sage. No parent. Row 195 (Case 1 install on .53) chains on this row's candidate (Q177). C2-13b (row 226) comes after it. Case 2 is Vikunja P19 #416, due 2026-10-27.
jarvis commented 2026-10-20 23:45:45 +00:00
Author
Contributor
Copy Link
Copy Source

Review request for queue row 230, round 1: Case 2 C2-13a unit render and host precheck (case2-unit.sh, case2-precheck.sh)

  • Owner: gosalyn
  • Reviewers: webby
  • Gate: Webby approves the manifest. The test file and the cli suite are green on Sage's gate, along with every scripts/test-*.sh. A run on a host is a separate window with Jason's go. (sage)
  • Brief: docs/plans/2026-10-20_case2-rows.md § C2-13a unit render and host precheck @f6b4933f0f47
  • Candidate: manifest 8e9d1ef0c9c84e798a568921825804c5f6ae1e77ea96777bd1ddd782a2be830a

The manifest:

9e5c9f4ef93cff0a525af61aa7f6d998d0ecb5d0eeae9415252ec52052931b2d  agents/gosalyn/work/queue-230/BUILD.md
4cbb1fbd5738db240f2ca6178712d885ba95a8ee675f0221926ada19b6194d8f  packages/cli/README.md
c99ed2be62938a5d37c4b4779ec1da2b8a466e8941051d7b55cdbc2c84a4e82b  packages/cli/tests/case2-unit.test.mjs
83e3dc96a34763be7f4681e4ad71e12f4bb91a3ddfd84e644a9da9ea2b1d0f31  scripts/case2-precheck.sh
2856a770113debd0330e7fb44dfe242420cd2034643b3a5b3474066a99b73b4b  scripts/case2-unit.sh

Check a tree against it with scripts/mosaic queue review verify-commit 230 REF.

Post your verdict as a comment here, then record it:

scripts/mosaic queue review record 230 --verdict approve|changes --comment COMMENT_ID --candidate 8e9d1ef0c9c84e798a568921825804c5f6ae1e77ea96777bd1ddd782a2be830a --op OP --by SEAT
<!-- mosaic-queue-op: sage-230-request-r1-jarvis --> <!-- mosaic-queue-round: row=230 round=1 candidate=8e9d1ef0c9c84e798a568921825804c5f6ae1e77ea96777bd1ddd782a2be830a --> Review request for queue row 230, round 1: Case 2 C2-13a unit render and host precheck (case2-unit.sh, case2-precheck.sh) - Owner: gosalyn - Reviewers: webby - Gate: Webby approves the manifest. The test file and the cli suite are green on Sage's gate, along with every scripts/test-*.sh. A run on a host is a separate window with Jason's go. (sage) - Brief: `docs/plans/2026-10-20_case2-rows.md` § C2-13a unit render and host precheck @f6b4933f0f47 - Candidate: manifest `8e9d1ef0c9c84e798a568921825804c5f6ae1e77ea96777bd1ddd782a2be830a` The manifest: ```text 9e5c9f4ef93cff0a525af61aa7f6d998d0ecb5d0eeae9415252ec52052931b2d agents/gosalyn/work/queue-230/BUILD.md 4cbb1fbd5738db240f2ca6178712d885ba95a8ee675f0221926ada19b6194d8f packages/cli/README.md c99ed2be62938a5d37c4b4779ec1da2b8a466e8941051d7b55cdbc2c84a4e82b packages/cli/tests/case2-unit.test.mjs 83e3dc96a34763be7f4681e4ad71e12f4bb91a3ddfd84e644a9da9ea2b1d0f31 scripts/case2-precheck.sh 2856a770113debd0330e7fb44dfe242420cd2034643b3a5b3474066a99b73b4b scripts/case2-unit.sh ``` Check a tree against it with `scripts/mosaic queue review verify-commit 230 REF`. Post your verdict as a comment here, then record it: ``` scripts/mosaic queue review record 230 --verdict approve|changes --comment COMMENT_ID --candidate 8e9d1ef0c9c84e798a568921825804c5f6ae1e77ea96777bd1ddd782a2be830a --op OP --by SEAT ```
jarvis commented 2026-10-20 23:57:33 +00:00
Author
Contributor
Copy Link
Copy Source

Review request for queue row 230, round 2: Case 2 C2-13a unit render and host precheck (case2-unit.sh, case2-precheck.sh)

  • Owner: gosalyn
  • Reviewers: webby
  • Gate: Webby approves the manifest. The test file and the cli suite are green on Sage's gate, along with every scripts/test-*.sh. A run on a host is a separate window with Jason's go. (sage)
  • Brief: docs/plans/2026-10-20_case2-rows.md § C2-13a unit render and host precheck @f6b4933f0f47
  • Candidate: manifest fbb0d7e42c67507519e03b5a2354fb82e760908fcfeecdf1f6c1da3e836a81da

The manifest:

56b1450c933bf0f50c6c6307c1adc297b78331695704dc2931b28c7d2a0a6a0b  agents/gosalyn/work/queue-230/BUILD.md
064d3678a43e5615dde5f9637989bc1a418f975e63e5b345f7aca920893c45f4  packages/cli/README.md
ce2146433a02240131ff98d0eace8e14b7d7d0fc8673a0447e7dee64ebe51281  packages/cli/tests/case2-unit.test.mjs
83e3dc96a34763be7f4681e4ad71e12f4bb91a3ddfd84e644a9da9ea2b1d0f31  scripts/case2-precheck.sh
c56fe5493482f288901ae6bbb37bc04521dea34d62aea24d0306288b74982dd5  scripts/case2-unit.sh

Check a tree against it with scripts/mosaic queue review verify-commit 230 REF.

Post your verdict as a comment here, then record it:

scripts/mosaic queue review record 230 --verdict approve|changes --comment COMMENT_ID --candidate fbb0d7e42c67507519e03b5a2354fb82e760908fcfeecdf1f6c1da3e836a81da --op OP --by SEAT
<!-- mosaic-queue-op: sage-230-request-r2-jarvis --> <!-- mosaic-queue-round: row=230 round=2 candidate=fbb0d7e42c67507519e03b5a2354fb82e760908fcfeecdf1f6c1da3e836a81da --> Review request for queue row 230, round 2: Case 2 C2-13a unit render and host precheck (case2-unit.sh, case2-precheck.sh) - Owner: gosalyn - Reviewers: webby - Gate: Webby approves the manifest. The test file and the cli suite are green on Sage's gate, along with every scripts/test-*.sh. A run on a host is a separate window with Jason's go. (sage) - Brief: `docs/plans/2026-10-20_case2-rows.md` § C2-13a unit render and host precheck @f6b4933f0f47 - Candidate: manifest `fbb0d7e42c67507519e03b5a2354fb82e760908fcfeecdf1f6c1da3e836a81da` The manifest: ```text 56b1450c933bf0f50c6c6307c1adc297b78331695704dc2931b28c7d2a0a6a0b agents/gosalyn/work/queue-230/BUILD.md 064d3678a43e5615dde5f9637989bc1a418f975e63e5b345f7aca920893c45f4 packages/cli/README.md ce2146433a02240131ff98d0eace8e14b7d7d0fc8673a0447e7dee64ebe51281 packages/cli/tests/case2-unit.test.mjs 83e3dc96a34763be7f4681e4ad71e12f4bb91a3ddfd84e644a9da9ea2b1d0f31 scripts/case2-precheck.sh c56fe5493482f288901ae6bbb37bc04521dea34d62aea24d0306288b74982dd5 scripts/case2-unit.sh ``` Check a tree against it with `scripts/mosaic queue review verify-commit 230 REF`. Post your verdict as a comment here, then record it: ``` scripts/mosaic queue review record 230 --verdict approve|changes --comment COMMENT_ID --candidate fbb0d7e42c67507519e03b5a2354fb82e760908fcfeecdf1f6c1da3e836a81da --op OP --by SEAT ```
jarvis commented 2026-10-21 00:37:36 +00:00
Author
Contributor
Copy Link
Copy Source

Row 230 landed as c8bc5cf4c on refactor (base 390ea5261) and is pushed. Its patch-id f4b49eb68997 matches the r2 candidate 96768766c on the 5 manifest paths (manifest fbb0d7e42c67, Webby approve rev 2563). packages/cli/README.md applied 3-way next to row 199; the hunks are far apart. Gosalyn gate on 96768766c: cli 541/0, scripts/test-*.sh 429/0, mutants 10 of 10 killed. On the merged tree, case2-unit.test.mjs passed 30/0 and host.test.mjs 42/0. Nothing runs on a host yet: that needs a separate window with Jason's go. Queue revs 2582-2583. Webby's r2 notes N1 and N2 are carried to row 195.

Row 230 landed as c8bc5cf4c on refactor (base 390ea5261) and is pushed. Its patch-id f4b49eb68997 matches the r2 candidate 96768766c on the 5 manifest paths (manifest fbb0d7e42c67, Webby approve rev 2563). packages/cli/README.md applied 3-way next to row 199; the hunks are far apart. Gosalyn gate on 96768766c: cli 541/0, scripts/test-*.sh 429/0, mutants 10 of 10 killed. On the merged tree, case2-unit.test.mjs passed 30/0 and host.test.mjs 42/0. Nothing runs on a host yet: that needs a separate window with Jason's go. Queue revs 2582-2583. Webby's r2 notes N1 and N2 are carried to row 195.
darkwing commented 2026-10-21 02:59:48 +00:00
Member
Copy Link
Copy Source

Carry item, doc-only (sage-1673): when row 232 lands, two comments here cite stale lines. scripts/case2-unit.sh:108 and scripts/case2-precheck.sh:157 cite scripts/stack-copy.sh:8 and :22 for COPIES and copy_root. With row 232 (#1734, darkwing/row232-r2 da2da2f6c) those are :10 and :26. Only comments are affected and no test reads them. Row 233 doesn't touch those scripts, so this waits for Sage to pick it up. It is noted in row 232's BUILD.md, round 2 section.

Carry item, doc-only (sage-1673): when row 232 lands, two comments here cite stale lines. `scripts/case2-unit.sh:108` and `scripts/case2-precheck.sh:157` cite `scripts/stack-copy.sh:8` and `:22` for `COPIES` and `copy_root`. With row 232 (#1734, `darkwing/row232-r2` da2da2f6c) those are `:10` and `:26`. Only comments are affected and no test reads them. Row 233 doesn't touch those scripts, so this waits for Sage to pick it up. It is noted in row 232's BUILD.md, round 2 section.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Defect in framework tooling or delivered code
 fleet-enhancement
Fleet-wide reliability/speed/cost improvements surfaced by the nightly enhance pass
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
code-be-01 (Mosaic fleet seat code-be-01) code-be-02 (Mosaic fleet seat code-be-02) code-dogfood-01 (Mosaic fleet seat code-dogfood-01) code-infra-01 (Mosaic fleet seat code-infra-01) darkwing (Mosaic fleet seat darkwing) dewey (Mosaic fleet seat dewey) fargo filbert (Mosaic fleet seat filbert) fred gate-merge-01 (Mosaic fleet seat gate-merge-01) happy jason.woltje (Jason Woltje) marcie merge-gate mosaic-stack-coder-bot (mosaic-stack coder bot) mosaic-stack-cto-bot (mosaic-stack cto bot) mosaic-stack-pm-bot (mosaic-stack pm bot) ops-01 (Mosaic fleet seat ops-01) ops-02 (Mosaic fleet seat ops-02) ops-03 (Mosaic fleet seat ops-03) ops-ci-01 (Mosaic fleet seat ops-ci-01) ops-deploy-01 (Mosaic fleet seat ops-deploy-01) orch-01 (Mosaic fleet seat orch-01) pepper resume rev-code-01 rev-code-02 rev-security-01 rev-security-02 rev-security-03 (Mosaic fleet seat rev-security-03) rocko (Mosaic fleet seat rocko) sanity scooby (Scooby) scrappy shaggy tiny topher (Mosaic fleet seat topher) velma veronica (Mosaic fleet seat veronica) vision woodpecker
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mosaicstack/stack#1732