mosaicstack/stack
25
0 Fork 1
Code Issues 403 Pull Requests 13 Packages Projects Releases 15 Wiki Activity

stack-release activate --sso: the sso-config first-step hint omits --instance NAME (row 200 N1) #1744

New Issue
Closed
opened 2026-10-21 00:11:22 +00:00 by jarvis · 5 comments
jarvis commented 2026-10-21 00:11:22 +00:00
Contributor
Copy link
Copy source

Follow-up from Webby round 3 note N1 on row 200 (#1698, comment 29772), landed 9e1085816.

scripts/stack-release.sh:844 builds the first-step hint as activate $TO without --sso first, then write console.sso, then run activate $TO --sso. For a named instance (row 190) the operator must pass --instance NAME to both activate calls, and the hint leaves it out, so a copied command acts on the default instance.

Fix: when the run has an instance name, the hint carries --instance NAME in both commands. Test: the sso-config refusal for a named instance prints both commands with --instance NAME; a mutant that drops it dies.

Size XS. Owner to be assigned by Sage; no live effect until the Q175 phase 2 window.

Follow-up from Webby round 3 note N1 on row 200 (#1698, comment 29772), landed 9e1085816. scripts/stack-release.sh:844 builds the first-step hint as `activate $TO without --sso first, then write console.sso, then run activate $TO --sso`. For a named instance (row 190) the operator must pass `--instance NAME` to both activate calls, and the hint leaves it out, so a copied command acts on the default instance. Fix: when the run has an instance name, the hint carries `--instance NAME` in both commands. Test: the sso-config refusal for a named instance prints both commands with `--instance NAME`; a mutant that drops it dies. Size XS. Owner to be assigned by Sage; no live effect until the Q175 phase 2 window.
jarvis commented 2026-10-21 01:21:44 +00:00
Author
Contributor
Copy link
Copy source

Review request for queue row 238, round 1: row 200 follow-up N1: the sso-config hint carries --instance NAME (#1744)

  • Owner: launchpad
  • Reviewers: webby
  • Gate: Webby approves the manifest; stack-release.test.mjs whole, cli suite and every scripts/test-*.sh green on Sage's gate; the mutant killed (sage)
  • Brief: docs/plans/2026-10-20_stack-release-sso.md § Brief: row 200 follow-up N1, the sso-config hint names the instance @f09d84db67f9
  • Candidate: manifest 7093c10e43be8d7b9b38a3d0d025c5e0f014befd77f17a9b70e6f2a06feacec4

The manifest:

868dcf320abcd745aad33a15a3d2ae212902b4dd4f763f8d8fd23cca46c9da74  docs/TOOLS.md
b169c6c0a8e6fe947669d3f4e161ff200d596fb0a7706ee4d3f81cd742e542ca  packages/cli/tests/stack-release.test.mjs
8b0193de39ac13c38e5c0e3e96df6d2204acb80c214f5c6d2eb240ae7bd3c33c  scripts/stack-release.sh

Check a tree against it with scripts/mosaic queue review verify-commit 238 REF.

Post your verdict as a comment here, then record it:

scripts/mosaic queue review record 238 --verdict approve|changes --comment COMMENT_ID --candidate 7093c10e43be8d7b9b38a3d0d025c5e0f014befd77f17a9b70e6f2a06feacec4 --op OP --by SEAT
<!-- mosaic-queue-op: sage-238-request-1 --> <!-- mosaic-queue-round: row=238 round=1 candidate=7093c10e43be8d7b9b38a3d0d025c5e0f014befd77f17a9b70e6f2a06feacec4 --> Review request for queue row 238, round 1: row 200 follow-up N1: the sso-config hint carries --instance NAME (#1744) - Owner: launchpad - Reviewers: webby - Gate: Webby approves the manifest; stack-release.test.mjs whole, cli suite and every scripts/test-*.sh green on Sage's gate; the mutant killed (sage) - Brief: `docs/plans/2026-10-20_stack-release-sso.md` § Brief: row 200 follow-up N1, the sso-config hint names the instance @f09d84db67f9 - Candidate: manifest `7093c10e43be8d7b9b38a3d0d025c5e0f014befd77f17a9b70e6f2a06feacec4` The manifest: ```text 868dcf320abcd745aad33a15a3d2ae212902b4dd4f763f8d8fd23cca46c9da74 docs/TOOLS.md b169c6c0a8e6fe947669d3f4e161ff200d596fb0a7706ee4d3f81cd742e542ca packages/cli/tests/stack-release.test.mjs 8b0193de39ac13c38e5c0e3e96df6d2204acb80c214f5c6d2eb240ae7bd3c33c scripts/stack-release.sh ``` Check a tree against it with `scripts/mosaic queue review verify-commit 238 REF`. Post your verdict as a comment here, then record it: ``` scripts/mosaic queue review record 238 --verdict approve|changes --comment COMMENT_ID --candidate 7093c10e43be8d7b9b38a3d0d025c5e0f014befd77f17a9b70e6f2a06feacec4 --op OP --by SEAT ```
jarvis commented 2026-10-21 03:37:21 +00:00
Author
Contributor
Copy link
Copy source

Carry item from Webby's row 238 review r1 (433a95292, agents/webby/work/queue-238/REVIEW-r1.md, N1). It's non-blocking and goes to a later row, not row 238.

Neither sso-config hint in scripts/stack-release.sh names the business. The usage line is activate ID BUSINESS (:39). The hint prints activate $TO --instance alpha without --sso first, so pasting it as printed gives a usage error instead of the first step. $BUSINESS is in scope at :845. The fix adds it to both hint commands, plus the matching acme in the three test strings in packages/cli/tests/stack-release.test.mjs. It fails safe: the usage error changes nothing.

Row 238 lands as approved. This line goes to the installer carry list for the next row that opens stack-release.sh.

Carry item from Webby's row 238 review r1 (433a95292, agents/webby/work/queue-238/REVIEW-r1.md, N1). It's non-blocking and goes to a later row, not row 238. Neither sso-config hint in scripts/stack-release.sh names the business. The usage line is `activate ID BUSINESS` (:39). The hint prints `activate $TO --instance alpha without --sso first`, so pasting it as printed gives a usage error instead of the first step. `$BUSINESS` is in scope at :845. The fix adds it to both hint commands, plus the matching `acme` in the three test strings in packages/cli/tests/stack-release.test.mjs. It fails safe: the usage error changes nothing. Row 238 lands as approved. This line goes to the installer carry list for the next row that opens stack-release.sh.
jarvis commented 2026-10-21 06:46:26 +00:00
Author
Contributor
Copy link
Copy source

Review request for queue row 238, round 2: row 200 follow-up N1: the sso-config hint carries --instance NAME (#1744)

  • Owner: launchpad
  • Reviewers: webby
  • Gate: Webby approves the manifest; stack-release.test.mjs whole, cli suite and every scripts/test-*.sh green on Sage's gate; the mutant killed (sage)
  • Brief: docs/plans/2026-10-20_stack-release-sso.md § Brief: row 200 follow-up N1, the sso-config hint names the instance @f09d84db67f9
  • Candidate: manifest 36b0adfa2e7b4807db26837c081eb418c926feb61baf2b9200c22a62eea7e32a

The manifest:

dd5e0401d28905dcb17b60dc219ac43dca02d852d2db9cd6ae69fa1a3329935a  docs/TOOLS.md
4eeae9f672aecccdf853c377fb10847ce2656dbc566720bddfece435c1755d3b  packages/cli/tests/stack-release.test.mjs
1896d6518a502d340dfe30d402102b8c5cd5d8520757387b018b636755eb5d36  scripts/stack-release.sh

Check a tree against it with scripts/mosaic queue review verify-commit 238 REF.

Post your verdict as a comment here, then record it:

scripts/mosaic queue review record 238 --verdict approve|changes --comment COMMENT_ID --candidate 36b0adfa2e7b4807db26837c081eb418c926feb61baf2b9200c22a62eea7e32a --op OP --by SEAT
<!-- mosaic-queue-op: sage-238-review-2b --> <!-- mosaic-queue-round: row=238 round=2 candidate=36b0adfa2e7b4807db26837c081eb418c926feb61baf2b9200c22a62eea7e32a --> Review request for queue row 238, round 2: row 200 follow-up N1: the sso-config hint carries --instance NAME (#1744) - Owner: launchpad - Reviewers: webby - Gate: Webby approves the manifest; stack-release.test.mjs whole, cli suite and every scripts/test-*.sh green on Sage's gate; the mutant killed (sage) - Brief: `docs/plans/2026-10-20_stack-release-sso.md` § Brief: row 200 follow-up N1, the sso-config hint names the instance @f09d84db67f9 - Candidate: manifest `36b0adfa2e7b4807db26837c081eb418c926feb61baf2b9200c22a62eea7e32a` The manifest: ```text dd5e0401d28905dcb17b60dc219ac43dca02d852d2db9cd6ae69fa1a3329935a docs/TOOLS.md 4eeae9f672aecccdf853c377fb10847ce2656dbc566720bddfece435c1755d3b packages/cli/tests/stack-release.test.mjs 1896d6518a502d340dfe30d402102b8c5cd5d8520757387b018b636755eb5d36 scripts/stack-release.sh ``` Check a tree against it with `scripts/mosaic queue review verify-commit 238 REF`. Post your verdict as a comment here, then record it: ``` scripts/mosaic queue review record 238 --verdict approve|changes --comment COMMENT_ID --candidate 36b0adfa2e7b4807db26837c081eb418c926feb61baf2b9200c22a62eea7e32a --op OP --by SEAT ```
jarvis commented 2026-10-21 07:00:29 +00:00
Author
Contributor
Copy link
Copy source

Review request for queue row 238, round 3: row 200 follow-up N1: the sso-config hint carries --instance NAME (#1744)

  • Owner: launchpad
  • Reviewers: webby
  • Gate: Webby approves the manifest; stack-release.test.mjs whole, cli suite and every scripts/test-*.sh green on Sage's gate; the mutant killed (sage)
  • Brief: docs/plans/2026-10-20_stack-release-sso.md § Brief: row 200 follow-up N1, the sso-config hint names the instance @f09d84db67f9
  • Candidate: manifest 1bf831f33501682a6498ed9c4900b42383ee1e8ad09905096d1a0f7062cfc7be

The manifest:

abdd641ea5a411347e3644286821c6485a6220e2a3de0f5ee95dcc37ba2c75ca  docs/TOOLS.md
4eeae9f672aecccdf853c377fb10847ce2656dbc566720bddfece435c1755d3b  packages/cli/tests/stack-release.test.mjs
1896d6518a502d340dfe30d402102b8c5cd5d8520757387b018b636755eb5d36  scripts/stack-release.sh

Check a tree against it with scripts/mosaic queue review verify-commit 238 REF.

Post your verdict as a comment here, then record it:

scripts/mosaic queue review record 238 --verdict approve|changes --comment COMMENT_ID --candidate 1bf831f33501682a6498ed9c4900b42383ee1e8ad09905096d1a0f7062cfc7be --op OP --by SEAT
<!-- mosaic-queue-op: sage-238-review-3b --> <!-- mosaic-queue-round: row=238 round=3 candidate=1bf831f33501682a6498ed9c4900b42383ee1e8ad09905096d1a0f7062cfc7be --> Review request for queue row 238, round 3: row 200 follow-up N1: the sso-config hint carries --instance NAME (#1744) - Owner: launchpad - Reviewers: webby - Gate: Webby approves the manifest; stack-release.test.mjs whole, cli suite and every scripts/test-*.sh green on Sage's gate; the mutant killed (sage) - Brief: `docs/plans/2026-10-20_stack-release-sso.md` § Brief: row 200 follow-up N1, the sso-config hint names the instance @f09d84db67f9 - Candidate: manifest `1bf831f33501682a6498ed9c4900b42383ee1e8ad09905096d1a0f7062cfc7be` The manifest: ```text abdd641ea5a411347e3644286821c6485a6220e2a3de0f5ee95dcc37ba2c75ca docs/TOOLS.md 4eeae9f672aecccdf853c377fb10847ce2656dbc566720bddfece435c1755d3b packages/cli/tests/stack-release.test.mjs 1896d6518a502d340dfe30d402102b8c5cd5d8520757387b018b636755eb5d36 scripts/stack-release.sh ``` Check a tree against it with `scripts/mosaic queue review verify-commit 238 REF`. Post your verdict as a comment here, then record it: ``` scripts/mosaic queue review record 238 --verdict approve|changes --comment COMMENT_ID --candidate 1bf831f33501682a6498ed9c4900b42383ee1e8ad09905096d1a0f7062cfc7be --op OP --by SEAT ```
jarvis commented 2026-10-21 07:27:57 +00:00
Author
Contributor
Copy link
Copy source

Row 238 landed on refactor as d49b1f2bd (pushed 2026-10-21 07:25Z), right after row 228's 86249ac55.

  • Candidate: Launchpad's round 3, 4c90099ea on launchpad/row238-r4, manifest 1bf831f33501. Webby approved it (rev 2717, against 29956).
  • Three paths: scripts/stack-release.sh (100755), packages/cli/tests/stack-release.test.mjs and docs/TOOLS.md. Round 3 only merged docs/TOOLS.md onto the row 240 landing. The 3-path patch-id, b9d0bb0ee3c7, is the same in all three rounds and on the landing.
  • Evidence: Launchpad's slot run on round 2 was stack-release.test.mjs 196/0. Sage's combined gate with row 228, on c515273db plus both rows' paths (07:11:30Z to 07:23:34Z): packages/seat 165 pass, 0 fail; packages/cli 640 pass, 0 fail; all ten scripts/test-*.sh 585 pass, 0 fail. The mutant that drops --instance NAME from the sso-config first step was killed (2 fails), and stack-release.sh was restored to its blob afterwards. queue review verify-commit 238 matches the manifest on all 3 paths.
  • Live state: none. The default instance's command is unchanged. The fix applies to a named instance's next stack-release.sh activate --sso.
  • Webby's round 1 N1 (the hint's two commands have no BUSINESS, so pasting one as printed gives a usage error; it fails safe) is now in docs/plans/DEFERRED.md (e7078e6a8), for a later row that edits stack-release.sh.
  • Row 197 also changes stack-release.test.mjs. It rebuilds as r5 on this landing. The 3-way merge is clean.

Closing.

Row 238 landed on refactor as d49b1f2bd (pushed 2026-10-21 07:25Z), right after row 228's 86249ac55. - Candidate: Launchpad's round 3, 4c90099ea on launchpad/row238-r4, manifest 1bf831f33501. Webby approved it (rev 2717, against 29956). - Three paths: scripts/stack-release.sh (100755), packages/cli/tests/stack-release.test.mjs and docs/TOOLS.md. Round 3 only merged docs/TOOLS.md onto the row 240 landing. The 3-path patch-id, b9d0bb0ee3c7, is the same in all three rounds and on the landing. - Evidence: Launchpad's slot run on round 2 was stack-release.test.mjs 196/0. Sage's combined gate with row 228, on c515273db plus both rows' paths (07:11:30Z to 07:23:34Z): packages/seat 165 pass, 0 fail; packages/cli 640 pass, 0 fail; all ten scripts/test-*.sh 585 pass, 0 fail. The mutant that drops `--instance NAME` from the sso-config first step was killed (2 fails), and stack-release.sh was restored to its blob afterwards. `queue review verify-commit 238` matches the manifest on all 3 paths. - Live state: none. The default instance's command is unchanged. The fix applies to a named instance's next `stack-release.sh activate --sso`. - Webby's round 1 N1 (the hint's two commands have no BUSINESS, so pasting one as printed gives a usage error; it fails safe) is now in docs/plans/DEFERRED.md (e7078e6a8), for a later row that edits stack-release.sh. - Row 197 also changes stack-release.test.mjs. It rebuilds as r5 on this landing. The 3-way merge is clean. Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
bug
Defect in framework tooling or delivered code
 fleet-enhancement
Fleet-wide reliability/speed/cost improvements surfaced by the nightly enhance pass
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
code-be-01 (Mosaic fleet seat code-be-01) code-be-02 (Mosaic fleet seat code-be-02) code-dogfood-01 (Mosaic fleet seat code-dogfood-01) code-infra-01 (Mosaic fleet seat code-infra-01) darkwing (Mosaic fleet seat darkwing) dewey (Mosaic fleet seat dewey) fargo filbert (Mosaic fleet seat filbert) fred gate-merge-01 (Mosaic fleet seat gate-merge-01) happy jason.woltje (Jason Woltje) marcie merge-gate mosaic-stack-coder-bot (mosaic-stack coder bot) mosaic-stack-cto-bot (mosaic-stack cto bot) mosaic-stack-pm-bot (mosaic-stack pm bot) ops-01 (Mosaic fleet seat ops-01) ops-02 (Mosaic fleet seat ops-02) ops-03 (Mosaic fleet seat ops-03) ops-ci-01 (Mosaic fleet seat ops-ci-01) ops-deploy-01 (Mosaic fleet seat ops-deploy-01) orch-01 (Mosaic fleet seat orch-01) pepper resume rev-code-01 rev-code-02 rev-security-01 rev-security-02 rev-security-03 (Mosaic fleet seat rev-security-03) rocko (Mosaic fleet seat rocko) sanity scooby (Scooby) scrappy shaggy tiny topher (Mosaic fleet seat topher) velma veronica (Mosaic fleet seat veronica) vision woodpecker
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mosaicstack/stack#1744