fix(orchestrator): resolve all M6 remediation issues (#260-#269)

Addresses all 10 quality remediation issues for the orchestrator module:

TypeScript & Type Safety:
- #260: Fix TypeScript compilation errors in tests
- #261: Replace explicit 'any' types with proper typed mocks

Error Handling & Reliability:
- #262: Fix silent cleanup failures - return structured results
- #263: Fix silent Valkey event parsing failures with proper error handling
- #266: Improve error context in Docker operations
- #267: Fix secret scanner false negatives on file read errors
- #268: Fix worktree cleanup error swallowing

Testing & Quality:
- #264: Add queue integration tests (coverage 15% → 85%)
- #265: Fix Prettier formatting violations
- #269: Update outdated TODO comments

All tests passing (406/406), TypeScript compiles cleanly, ESLint clean.

Fixes #260, Fixes #261, Fixes #262, Fixes #263, Fixes #264
Fixes #265, Fixes #266, Fixes #267, Fixes #268, Fixes #269

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

apps/orchestrator/src/api/agents/agents-killswitch.controller.spec.ts

@@ -0,0 +1,158 @@
+import { describe, it, expect, beforeEach, afterEach, vi } from "vitest";
+import { AgentsController } from "./agents.controller";
+import { QueueService } from "../../queue/queue.service";
+import { AgentSpawnerService } from "../../spawner/agent-spawner.service";
+import { KillswitchService } from "../../killswitch/killswitch.service";
+import type { KillAllResult } from "../../killswitch/killswitch.service";
+
+describe("AgentsController - Killswitch Endpoints", () => {
+  let controller: AgentsController;
+  let mockKillswitchService: {
+    killAgent: ReturnType<typeof vi.fn>;
+    killAllAgents: ReturnType<typeof vi.fn>;
+  };
+  let mockQueueService: {
+    addTask: ReturnType<typeof vi.fn>;
+  };
+  let mockSpawnerService: {
+    spawnAgent: ReturnType<typeof vi.fn>;
+  };
+
+  beforeEach(() => {
+    mockKillswitchService = {
+      killAgent: vi.fn(),
+      killAllAgents: vi.fn(),
+    };
+
+    mockQueueService = {
+      addTask: vi.fn(),
+    };
+
+    mockSpawnerService = {
+      spawnAgent: vi.fn(),
+    };
+
+    controller = new AgentsController(
+      mockQueueService as unknown as QueueService,
+      mockSpawnerService as unknown as AgentSpawnerService,
+      mockKillswitchService as unknown as KillswitchService
+    );
+  });
+
+  afterEach(() => {
+    vi.clearAllMocks();
+  });
+
+  describe("POST /agents/:agentId/kill", () => {
+    it("should kill single agent successfully", async () => {
+      // Arrange
+      const agentId = "agent-123";
+      mockKillswitchService.killAgent.mockResolvedValue(undefined);
+
+      // Act
+      const result = await controller.killAgent(agentId);
+
+      // Assert
+      expect(mockKillswitchService.killAgent).toHaveBeenCalledWith(agentId);
+      expect(result).toEqual({
+        message: `Agent ${agentId} killed successfully`,
+      });
+    });
+
+    it("should throw error if agent not found", async () => {
+      // Arrange
+      const agentId = "agent-999";
+      mockKillswitchService.killAgent.mockRejectedValue(new Error("Agent agent-999 not found"));
+
+      // Act & Assert
+      await expect(controller.killAgent(agentId)).rejects.toThrow("Agent agent-999 not found");
+    });
+
+    it("should throw error if state transition fails", async () => {
+      // Arrange
+      const agentId = "agent-123";
+      mockKillswitchService.killAgent.mockRejectedValue(new Error("Invalid state transition"));
+
+      // Act & Assert
+      await expect(controller.killAgent(agentId)).rejects.toThrow("Invalid state transition");
+    });
+  });
+
+  describe("POST /agents/kill-all", () => {
+    it("should kill all agents successfully", async () => {
+      // Arrange
+      const killAllResult: KillAllResult = {
+        total: 3,
+        killed: 3,
+        failed: 0,
+      };
+      mockKillswitchService.killAllAgents.mockResolvedValue(killAllResult);
+
+      // Act
+      const result = await controller.killAllAgents();
+
+      // Assert
+      expect(mockKillswitchService.killAllAgents).toHaveBeenCalled();
+      expect(result).toEqual({
+        message: "Kill all completed: 3 killed, 0 failed",
+        total: 3,
+        killed: 3,
+        failed: 0,
+      });
+    });
+
+    it("should return partial results when some agents fail", async () => {
+      // Arrange
+      const killAllResult: KillAllResult = {
+        total: 3,
+        killed: 2,
+        failed: 1,
+        errors: ["Failed to kill agent agent-2: State transition failed"],
+      };
+      mockKillswitchService.killAllAgents.mockResolvedValue(killAllResult);
+
+      // Act
+      const result = await controller.killAllAgents();
+
+      // Assert
+      expect(mockKillswitchService.killAllAgents).toHaveBeenCalled();
+      expect(result).toEqual({
+        message: "Kill all completed: 2 killed, 1 failed",
+        total: 3,
+        killed: 2,
+        failed: 1,
+        errors: ["Failed to kill agent agent-2: State transition failed"],
+      });
+    });
+
+    it("should return zero results when no agents exist", async () => {
+      // Arrange
+      const killAllResult: KillAllResult = {
+        total: 0,
+        killed: 0,
+        failed: 0,
+      };
+      mockKillswitchService.killAllAgents.mockResolvedValue(killAllResult);
+
+      // Act
+      const result = await controller.killAllAgents();
+
+      // Assert
+      expect(mockKillswitchService.killAllAgents).toHaveBeenCalled();
+      expect(result).toEqual({
+        message: "Kill all completed: 0 killed, 0 failed",
+        total: 0,
+        killed: 0,
+        failed: 0,
+      });
+    });
+
+    it("should throw error if killswitch service fails", async () => {
+      // Arrange
+      mockKillswitchService.killAllAgents.mockRejectedValue(new Error("Internal error"));
+
+      // Act & Assert
+      await expect(controller.killAllAgents()).rejects.toThrow("Internal error");
+    });
+  });
+});

apps/orchestrator/src/api/agents/agents.controller.spec.ts

@@ -0,0 +1,296 @@
+import { AgentsController } from "./agents.controller";
+import { QueueService } from "../../queue/queue.service";
+import { AgentSpawnerService } from "../../spawner/agent-spawner.service";
+import { KillswitchService } from "../../killswitch/killswitch.service";
+import { BadRequestException } from "@nestjs/common";
+import { describe, it, expect, beforeEach, afterEach, vi } from "vitest";
+
+describe("AgentsController", () => {
+  let controller: AgentsController;
+  let queueService: {
+    addTask: ReturnType<typeof vi.fn>;
+  };
+  let spawnerService: {
+    spawnAgent: ReturnType<typeof vi.fn>;
+  };
+  let killswitchService: {
+    killAgent: ReturnType<typeof vi.fn>;
+    killAllAgents: ReturnType<typeof vi.fn>;
+  };
+
+  beforeEach(() => {
+    // Create mock services
+    queueService = {
+      addTask: vi.fn().mockResolvedValue(undefined),
+    };
+
+    spawnerService = {
+      spawnAgent: vi.fn(),
+    };
+
+    killswitchService = {
+      killAgent: vi.fn(),
+      killAllAgents: vi.fn(),
+    };
+
+    // Create controller with mocked services
+    controller = new AgentsController(
+      queueService as unknown as QueueService,
+      spawnerService as unknown as AgentSpawnerService,
+      killswitchService as unknown as KillswitchService
+    );
+  });
+
+  afterEach(() => {
+    vi.clearAllMocks();
+  });
+
+  it("should be defined", () => {
+    expect(controller).toBeDefined();
+  });
+
+  describe("spawn", () => {
+    const validRequest = {
+      taskId: "task-123",
+      agentType: "worker" as const,
+      context: {
+        repository: "https://github.com/org/repo.git",
+        branch: "main",
+        workItems: ["US-001", "US-002"],
+        skills: ["typescript", "nestjs"],
+      },
+    };
+
+    it("should spawn agent and queue task successfully", async () => {
+      // Arrange
+      const agentId = "agent-abc-123";
+      const spawnedAt = new Date();
+      spawnerService.spawnAgent.mockReturnValue({
+        agentId,
+        state: "spawning",
+        spawnedAt,
+      });
+      queueService.addTask.mockResolvedValue(undefined);
+
+      // Act
+      const result = await controller.spawn(validRequest);
+
+      // Assert
+      expect(spawnerService.spawnAgent).toHaveBeenCalledWith(validRequest);
+      expect(queueService.addTask).toHaveBeenCalledWith(validRequest.taskId, validRequest.context, {
+        priority: 5,
+      });
+      expect(result).toEqual({
+        agentId,
+        status: "spawning",
+      });
+    });
+
+    it("should return queued status when agent is queued", async () => {
+      // Arrange
+      const agentId = "agent-abc-123";
+      spawnerService.spawnAgent.mockReturnValue({
+        agentId,
+        state: "spawning",
+        spawnedAt: new Date(),
+      });
+      queueService.addTask.mockResolvedValue(undefined);
+
+      // Act
+      const result = await controller.spawn(validRequest);
+
+      // Assert
+      expect(result.status).toBe("spawning");
+    });
+
+    it("should handle reviewer agent type", async () => {
+      // Arrange
+      const reviewerRequest = {
+        ...validRequest,
+        agentType: "reviewer" as const,
+      };
+      const agentId = "agent-reviewer-123";
+      spawnerService.spawnAgent.mockReturnValue({
+        agentId,
+        state: "spawning",
+        spawnedAt: new Date(),
+      });
+      queueService.addTask.mockResolvedValue(undefined);
+
+      // Act
+      const result = await controller.spawn(reviewerRequest);
+
+      // Assert
+      expect(spawnerService.spawnAgent).toHaveBeenCalledWith(reviewerRequest);
+      expect(result.agentId).toBe(agentId);
+    });
+
+    it("should handle tester agent type", async () => {
+      // Arrange
+      const testerRequest = {
+        ...validRequest,
+        agentType: "tester" as const,
+      };
+      const agentId = "agent-tester-123";
+      spawnerService.spawnAgent.mockReturnValue({
+        agentId,
+        state: "spawning",
+        spawnedAt: new Date(),
+      });
+      queueService.addTask.mockResolvedValue(undefined);
+
+      // Act
+      const result = await controller.spawn(testerRequest);
+
+      // Assert
+      expect(spawnerService.spawnAgent).toHaveBeenCalledWith(testerRequest);
+      expect(result.agentId).toBe(agentId);
+    });
+
+    it("should handle missing optional skills", async () => {
+      // Arrange
+      const requestWithoutSkills = {
+        taskId: "task-123",
+        agentType: "worker" as const,
+        context: {
+          repository: "https://github.com/org/repo.git",
+          branch: "main",
+          workItems: ["US-001"],
+        },
+      };
+      const agentId = "agent-abc-123";
+      spawnerService.spawnAgent.mockReturnValue({
+        agentId,
+        state: "spawning",
+        spawnedAt: new Date(),
+      });
+      queueService.addTask.mockResolvedValue(undefined);
+
+      // Act
+      const result = await controller.spawn(requestWithoutSkills);
+
+      // Assert
+      expect(result.agentId).toBe(agentId);
+    });
+
+    it("should throw BadRequestException when taskId is missing", async () => {
+      // Arrange
+      const invalidRequest = {
+        agentType: "worker" as const,
+        context: validRequest.context,
+      } as unknown as typeof validRequest;
+
+      // Act & Assert
+      await expect(controller.spawn(invalidRequest)).rejects.toThrow(BadRequestException);
+      expect(spawnerService.spawnAgent).not.toHaveBeenCalled();
+      expect(queueService.addTask).not.toHaveBeenCalled();
+    });
+
+    it("should throw BadRequestException when agentType is invalid", async () => {
+      // Arrange
+      const invalidRequest = {
+        ...validRequest,
+        agentType: "invalid" as unknown as "worker",
+      };
+
+      // Act & Assert
+      await expect(controller.spawn(invalidRequest)).rejects.toThrow(BadRequestException);
+      expect(spawnerService.spawnAgent).not.toHaveBeenCalled();
+      expect(queueService.addTask).not.toHaveBeenCalled();
+    });
+
+    it("should throw BadRequestException when repository is missing", async () => {
+      // Arrange
+      const invalidRequest = {
+        ...validRequest,
+        context: {
+          ...validRequest.context,
+          repository: "",
+        },
+      };
+
+      // Act & Assert
+      await expect(controller.spawn(invalidRequest)).rejects.toThrow(BadRequestException);
+      expect(spawnerService.spawnAgent).not.toHaveBeenCalled();
+      expect(queueService.addTask).not.toHaveBeenCalled();
+    });
+
+    it("should throw BadRequestException when branch is missing", async () => {
+      // Arrange
+      const invalidRequest = {
+        ...validRequest,
+        context: {
+          ...validRequest.context,
+          branch: "",
+        },
+      };
+
+      // Act & Assert
+      await expect(controller.spawn(invalidRequest)).rejects.toThrow(BadRequestException);
+      expect(spawnerService.spawnAgent).not.toHaveBeenCalled();
+      expect(queueService.addTask).not.toHaveBeenCalled();
+    });
+
+    it("should throw BadRequestException when workItems is empty", async () => {
+      // Arrange
+      const invalidRequest = {
+        ...validRequest,
+        context: {
+          ...validRequest.context,
+          workItems: [],
+        },
+      };
+
+      // Act & Assert
+      await expect(controller.spawn(invalidRequest)).rejects.toThrow(BadRequestException);
+      expect(spawnerService.spawnAgent).not.toHaveBeenCalled();
+      expect(queueService.addTask).not.toHaveBeenCalled();
+    });
+
+    it("should propagate errors from spawner service", async () => {
+      // Arrange
+      const error = new Error("Spawner failed");
+      spawnerService.spawnAgent.mockImplementation(() => {
+        throw error;
+      });
+
+      // Act & Assert
+      await expect(controller.spawn(validRequest)).rejects.toThrow("Spawner failed");
+      expect(queueService.addTask).not.toHaveBeenCalled();
+    });
+
+    it("should propagate errors from queue service", async () => {
+      // Arrange
+      const agentId = "agent-abc-123";
+      spawnerService.spawnAgent.mockReturnValue({
+        agentId,
+        state: "spawning",
+        spawnedAt: new Date(),
+      });
+      const error = new Error("Queue failed");
+      queueService.addTask.mockRejectedValue(error);
+
+      // Act & Assert
+      await expect(controller.spawn(validRequest)).rejects.toThrow("Queue failed");
+    });
+
+    it("should use default priority of 5", async () => {
+      // Arrange
+      const agentId = "agent-abc-123";
+      spawnerService.spawnAgent.mockReturnValue({
+        agentId,
+        state: "spawning",
+        spawnedAt: new Date(),
+      });
+      queueService.addTask.mockResolvedValue(undefined);
+
+      // Act
+      await controller.spawn(validRequest);
+
+      // Assert
+      expect(queueService.addTask).toHaveBeenCalledWith(validRequest.taskId, validRequest.context, {
+        priority: 5,
+      });
+    });
+  });
+});

apps/orchestrator/src/api/agents/agents.controller.ts

@@ -0,0 +1,152 @@
+import {
+  Controller,
+  Post,
+  Body,
+  Param,
+  BadRequestException,
+  Logger,
+  UsePipes,
+  ValidationPipe,
+  HttpCode,
+} from "@nestjs/common";
+import { QueueService } from "../../queue/queue.service";
+import { AgentSpawnerService } from "../../spawner/agent-spawner.service";
+import { KillswitchService } from "../../killswitch/killswitch.service";
+import { SpawnAgentDto, SpawnAgentResponseDto } from "./dto/spawn-agent.dto";
+
+/**
+ * Controller for agent management endpoints
+ */
+@Controller("agents")
+export class AgentsController {
+  private readonly logger = new Logger(AgentsController.name);
+
+  constructor(
+    private readonly queueService: QueueService,
+    private readonly spawnerService: AgentSpawnerService,
+    private readonly killswitchService: KillswitchService
+  ) {}
+
+  /**
+   * Spawn a new agent for the given task
+   * @param dto Spawn agent request
+   * @returns Agent spawn response with agentId and status
+   */
+  @Post("spawn")
+  @UsePipes(new ValidationPipe({ transform: true, whitelist: true }))
+  async spawn(@Body() dto: SpawnAgentDto): Promise<SpawnAgentResponseDto> {
+    this.logger.log(`Received spawn request for task: ${dto.taskId}`);
+
+    try {
+      // Validate request manually (in addition to ValidationPipe)
+      this.validateSpawnRequest(dto);
+
+      // Spawn agent using spawner service
+      const spawnResponse = this.spawnerService.spawnAgent({
+        taskId: dto.taskId,
+        agentType: dto.agentType,
+        context: dto.context,
+      });
+
+      // Queue task in Valkey
+      await this.queueService.addTask(dto.taskId, dto.context, {
+        priority: 5, // Default priority
+      });
+
+      this.logger.log(`Agent spawned successfully: ${spawnResponse.agentId}`);
+
+      // Return response
+      return {
+        agentId: spawnResponse.agentId,
+        status: "spawning",
+      };
+    } catch (error) {
+      this.logger.error(`Failed to spawn agent: ${String(error)}`);
+      throw error;
+    }
+  }
+
+  /**
+   * Kill a single agent immediately
+   * @param agentId Agent ID to kill
+   * @returns Success message
+   */
+  @Post(":agentId/kill")
+  @HttpCode(200)
+  async killAgent(@Param("agentId") agentId: string): Promise<{ message: string }> {
+    this.logger.warn(`Received kill request for agent: ${agentId}`);
+
+    try {
+      await this.killswitchService.killAgent(agentId);
+
+      this.logger.warn(`Agent ${agentId} killed successfully`);
+
+      return {
+        message: `Agent ${agentId} killed successfully`,
+      };
+    } catch (error) {
+      this.logger.error(`Failed to kill agent ${agentId}: ${String(error)}`);
+      throw error;
+    }
+  }
+
+  /**
+   * Kill all active agents
+   * @returns Summary of kill operation
+   */
+  @Post("kill-all")
+  @HttpCode(200)
+  async killAllAgents(): Promise<{
+    message: string;
+    total: number;
+    killed: number;
+    failed: number;
+    errors?: string[];
+  }> {
+    this.logger.warn("Received kill-all request");
+
+    try {
+      const result = await this.killswitchService.killAllAgents();
+
+      this.logger.warn(
+        `Kill all completed: ${result.killed.toString()} killed, ${result.failed.toString()} failed out of ${result.total.toString()}`
+      );
+
+      return {
+        message: `Kill all completed: ${result.killed.toString()} killed, ${result.failed.toString()} failed`,
+        ...result,
+      };
+    } catch (error) {
+      this.logger.error(`Failed to kill all agents: ${String(error)}`);
+      throw error;
+    }
+  }
+
+  /**
+   * Validate spawn request
+   * @param dto Spawn request to validate
+   * @throws BadRequestException if validation fails
+   */
+  private validateSpawnRequest(dto: SpawnAgentDto): void {
+    if (!dto.taskId || dto.taskId.trim() === "") {
+      throw new BadRequestException("taskId is required");
+    }
+
+    const validAgentTypes = ["worker", "reviewer", "tester"];
+    if (!validAgentTypes.includes(dto.agentType)) {
+      throw new BadRequestException(`agentType must be one of: ${validAgentTypes.join(", ")}`);
+    }
+
+    if (!dto.context.repository || dto.context.repository.trim() === "") {
+      throw new BadRequestException("context.repository is required");
+    }
+
+    if (!dto.context.branch || dto.context.branch.trim() === "") {
+      throw new BadRequestException("context.branch is required");
+    }
+
+    if (dto.context.workItems.length === 0) {
+      throw new BadRequestException("context.workItems must not be empty");
+    }
+  }
+}

apps/orchestrator/src/api/agents/agents.module.ts

@@ -0,0 +1,11 @@
+import { Module } from "@nestjs/common";
+import { AgentsController } from "./agents.controller";
+import { QueueModule } from "../../queue/queue.module";
+import { SpawnerModule } from "../../spawner/spawner.module";
+import { KillswitchModule } from "../../killswitch/killswitch.module";
+
+@Module({
+  imports: [QueueModule, SpawnerModule, KillswitchModule],
+  controllers: [AgentsController],
+})
+export class AgentsModule {}

apps/orchestrator/src/api/agents/dto/spawn-agent.dto.ts

@@ -0,0 +1,64 @@
+import {
+  IsString,
+  IsNotEmpty,
+  IsEnum,
+  ValidateNested,
+  IsArray,
+  IsOptional,
+  ArrayNotEmpty,
+  IsIn,
+} from "class-validator";
+import { Type } from "class-transformer";
+import { AgentType } from "../../../spawner/types/agent-spawner.types";
+import { GateProfileType } from "../../../coordinator/types/gate-config.types";
+
+/**
+ * Context DTO for agent spawn request
+ */
+export class AgentContextDto {
+  @IsString()
+  @IsNotEmpty()
+  repository!: string;
+
+  @IsString()
+  @IsNotEmpty()
+  branch!: string;
+
+  @IsArray()
+  @ArrayNotEmpty()
+  @IsString({ each: true })
+  workItems!: string[];
+
+  @IsArray()
+  @IsOptional()
+  @IsString({ each: true })
+  skills?: string[];
+}
+
+/**
+ * Request DTO for spawning an agent
+ */
+export class SpawnAgentDto {
+  @IsString()
+  @IsNotEmpty()
+  taskId!: string;
+
+  @IsEnum(["worker", "reviewer", "tester"])
+  agentType!: AgentType;
+
+  @ValidateNested()
+  @Type(() => AgentContextDto)
+  context!: AgentContextDto;
+
+  @IsOptional()
+  @IsIn(["strict", "standard", "minimal", "custom"])
+  gateProfile?: GateProfileType;
+}
+
+/**
+ * Response DTO for spawn agent endpoint
+ */
+export class SpawnAgentResponseDto {
+  agentId!: string;
+  status!: "spawning" | "queued";
+}