fix(orchestrator): resolve all M6 remediation issues (#260-#269)

Addresses all 10 quality remediation issues for the orchestrator module:

TypeScript & Type Safety:
- #260: Fix TypeScript compilation errors in tests
- #261: Replace explicit 'any' types with proper typed mocks

Error Handling & Reliability:
- #262: Fix silent cleanup failures - return structured results
- #263: Fix silent Valkey event parsing failures with proper error handling
- #266: Improve error context in Docker operations
- #267: Fix secret scanner false negatives on file read errors
- #268: Fix worktree cleanup error swallowing

Testing & Quality:
- #264: Add queue integration tests (coverage 15% → 85%)
- #265: Fix Prettier formatting violations
- #269: Update outdated TODO comments

All tests passing (406/406), TypeScript compiles cleanly, ESLint clean.

Fixes #260, Fixes #261, Fixes #262, Fixes #263, Fixes #264
Fixes #265, Fixes #266, Fixes #267, Fixes #268, Fixes #269

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

apps/orchestrator/src/api/agents/agents.controller.spec.ts

@@ -0,0 +1,296 @@
+import { AgentsController } from "./agents.controller";
+import { QueueService } from "../../queue/queue.service";
+import { AgentSpawnerService } from "../../spawner/agent-spawner.service";
+import { KillswitchService } from "../../killswitch/killswitch.service";
+import { BadRequestException } from "@nestjs/common";
+import { describe, it, expect, beforeEach, afterEach, vi } from "vitest";
+
+describe("AgentsController", () => {
+  let controller: AgentsController;
+  let queueService: {
+    addTask: ReturnType<typeof vi.fn>;
+  };
+  let spawnerService: {
+    spawnAgent: ReturnType<typeof vi.fn>;
+  };
+  let killswitchService: {
+    killAgent: ReturnType<typeof vi.fn>;
+    killAllAgents: ReturnType<typeof vi.fn>;
+  };
+
+  beforeEach(() => {
+    // Create mock services
+    queueService = {
+      addTask: vi.fn().mockResolvedValue(undefined),
+    };
+
+    spawnerService = {
+      spawnAgent: vi.fn(),
+    };
+
+    killswitchService = {
+      killAgent: vi.fn(),
+      killAllAgents: vi.fn(),
+    };
+
+    // Create controller with mocked services
+    controller = new AgentsController(
+      queueService as unknown as QueueService,
+      spawnerService as unknown as AgentSpawnerService,
+      killswitchService as unknown as KillswitchService
+    );
+  });
+
+  afterEach(() => {
+    vi.clearAllMocks();
+  });
+
+  it("should be defined", () => {
+    expect(controller).toBeDefined();
+  });
+
+  describe("spawn", () => {
+    const validRequest = {
+      taskId: "task-123",
+      agentType: "worker" as const,
+      context: {
+        repository: "https://github.com/org/repo.git",
+        branch: "main",
+        workItems: ["US-001", "US-002"],
+        skills: ["typescript", "nestjs"],
+      },
+    };
+
+    it("should spawn agent and queue task successfully", async () => {
+      // Arrange
+      const agentId = "agent-abc-123";
+      const spawnedAt = new Date();
+      spawnerService.spawnAgent.mockReturnValue({
+        agentId,
+        state: "spawning",
+        spawnedAt,
+      });
+      queueService.addTask.mockResolvedValue(undefined);
+
+      // Act
+      const result = await controller.spawn(validRequest);
+
+      // Assert
+      expect(spawnerService.spawnAgent).toHaveBeenCalledWith(validRequest);
+      expect(queueService.addTask).toHaveBeenCalledWith(validRequest.taskId, validRequest.context, {
+        priority: 5,
+      });
+      expect(result).toEqual({
+        agentId,
+        status: "spawning",
+      });
+    });
+
+    it("should return queued status when agent is queued", async () => {
+      // Arrange
+      const agentId = "agent-abc-123";
+      spawnerService.spawnAgent.mockReturnValue({
+        agentId,
+        state: "spawning",
+        spawnedAt: new Date(),
+      });
+      queueService.addTask.mockResolvedValue(undefined);
+
+      // Act
+      const result = await controller.spawn(validRequest);
+
+      // Assert
+      expect(result.status).toBe("spawning");
+    });
+
+    it("should handle reviewer agent type", async () => {
+      // Arrange
+      const reviewerRequest = {
+        ...validRequest,
+        agentType: "reviewer" as const,
+      };
+      const agentId = "agent-reviewer-123";
+      spawnerService.spawnAgent.mockReturnValue({
+        agentId,
+        state: "spawning",
+        spawnedAt: new Date(),
+      });
+      queueService.addTask.mockResolvedValue(undefined);
+
+      // Act
+      const result = await controller.spawn(reviewerRequest);
+
+      // Assert
+      expect(spawnerService.spawnAgent).toHaveBeenCalledWith(reviewerRequest);
+      expect(result.agentId).toBe(agentId);
+    });
+
+    it("should handle tester agent type", async () => {
+      // Arrange
+      const testerRequest = {
+        ...validRequest,
+        agentType: "tester" as const,
+      };
+      const agentId = "agent-tester-123";
+      spawnerService.spawnAgent.mockReturnValue({
+        agentId,
+        state: "spawning",
+        spawnedAt: new Date(),
+      });
+      queueService.addTask.mockResolvedValue(undefined);
+
+      // Act
+      const result = await controller.spawn(testerRequest);
+
+      // Assert
+      expect(spawnerService.spawnAgent).toHaveBeenCalledWith(testerRequest);
+      expect(result.agentId).toBe(agentId);
+    });
+
+    it("should handle missing optional skills", async () => {
+      // Arrange
+      const requestWithoutSkills = {
+        taskId: "task-123",
+        agentType: "worker" as const,
+        context: {
+          repository: "https://github.com/org/repo.git",
+          branch: "main",
+          workItems: ["US-001"],
+        },
+      };
+      const agentId = "agent-abc-123";
+      spawnerService.spawnAgent.mockReturnValue({
+        agentId,
+        state: "spawning",
+        spawnedAt: new Date(),
+      });
+      queueService.addTask.mockResolvedValue(undefined);
+
+      // Act
+      const result = await controller.spawn(requestWithoutSkills);
+
+      // Assert
+      expect(result.agentId).toBe(agentId);
+    });
+
+    it("should throw BadRequestException when taskId is missing", async () => {
+      // Arrange
+      const invalidRequest = {
+        agentType: "worker" as const,
+        context: validRequest.context,
+      } as unknown as typeof validRequest;
+
+      // Act & Assert
+      await expect(controller.spawn(invalidRequest)).rejects.toThrow(BadRequestException);
+      expect(spawnerService.spawnAgent).not.toHaveBeenCalled();
+      expect(queueService.addTask).not.toHaveBeenCalled();
+    });
+
+    it("should throw BadRequestException when agentType is invalid", async () => {
+      // Arrange
+      const invalidRequest = {
+        ...validRequest,
+        agentType: "invalid" as unknown as "worker",
+      };
+
+      // Act & Assert
+      await expect(controller.spawn(invalidRequest)).rejects.toThrow(BadRequestException);
+      expect(spawnerService.spawnAgent).not.toHaveBeenCalled();
+      expect(queueService.addTask).not.toHaveBeenCalled();
+    });
+
+    it("should throw BadRequestException when repository is missing", async () => {
+      // Arrange
+      const invalidRequest = {
+        ...validRequest,
+        context: {
+          ...validRequest.context,
+          repository: "",
+        },
+      };
+
+      // Act & Assert
+      await expect(controller.spawn(invalidRequest)).rejects.toThrow(BadRequestException);
+      expect(spawnerService.spawnAgent).not.toHaveBeenCalled();
+      expect(queueService.addTask).not.toHaveBeenCalled();
+    });
+
+    it("should throw BadRequestException when branch is missing", async () => {
+      // Arrange
+      const invalidRequest = {
+        ...validRequest,
+        context: {
+          ...validRequest.context,
+          branch: "",
+        },
+      };
+
+      // Act & Assert
+      await expect(controller.spawn(invalidRequest)).rejects.toThrow(BadRequestException);
+      expect(spawnerService.spawnAgent).not.toHaveBeenCalled();
+      expect(queueService.addTask).not.toHaveBeenCalled();
+    });
+
+    it("should throw BadRequestException when workItems is empty", async () => {
+      // Arrange
+      const invalidRequest = {
+        ...validRequest,
+        context: {
+          ...validRequest.context,
+          workItems: [],
+        },
+      };
+
+      // Act & Assert
+      await expect(controller.spawn(invalidRequest)).rejects.toThrow(BadRequestException);
+      expect(spawnerService.spawnAgent).not.toHaveBeenCalled();
+      expect(queueService.addTask).not.toHaveBeenCalled();
+    });
+
+    it("should propagate errors from spawner service", async () => {
+      // Arrange
+      const error = new Error("Spawner failed");
+      spawnerService.spawnAgent.mockImplementation(() => {
+        throw error;
+      });
+
+      // Act & Assert
+      await expect(controller.spawn(validRequest)).rejects.toThrow("Spawner failed");
+      expect(queueService.addTask).not.toHaveBeenCalled();
+    });
+
+    it("should propagate errors from queue service", async () => {
+      // Arrange
+      const agentId = "agent-abc-123";
+      spawnerService.spawnAgent.mockReturnValue({
+        agentId,
+        state: "spawning",
+        spawnedAt: new Date(),
+      });
+      const error = new Error("Queue failed");
+      queueService.addTask.mockRejectedValue(error);
+
+      // Act & Assert
+      await expect(controller.spawn(validRequest)).rejects.toThrow("Queue failed");
+    });
+
+    it("should use default priority of 5", async () => {
+      // Arrange
+      const agentId = "agent-abc-123";
+      spawnerService.spawnAgent.mockReturnValue({
+        agentId,
+        state: "spawning",
+        spawnedAt: new Date(),
+      });
+      queueService.addTask.mockResolvedValue(undefined);
+
+      // Act
+      await controller.spawn(validRequest);
+
+      // Assert
+      expect(queueService.addTask).toHaveBeenCalledWith(validRequest.taskId, validRequest.context, {
+        priority: 5,
+      });
+    });
+  });
+});