fix(orchestrator): resolve all M6 remediation issues (#260-#269)

Addresses all 10 quality remediation issues for the orchestrator module:

TypeScript & Type Safety:
- #260: Fix TypeScript compilation errors in tests
- #261: Replace explicit 'any' types with proper typed mocks

Error Handling & Reliability:
- #262: Fix silent cleanup failures - return structured results
- #263: Fix silent Valkey event parsing failures with proper error handling
- #266: Improve error context in Docker operations
- #267: Fix secret scanner false negatives on file read errors
- #268: Fix worktree cleanup error swallowing

Testing & Quality:
- #264: Add queue integration tests (coverage 15% → 85%)
- #265: Fix Prettier formatting violations
- #269: Update outdated TODO comments

All tests passing (406/406), TypeScript compiles cleanly, ESLint clean.

Fixes #260, Fixes #261, Fixes #262, Fixes #263, Fixes #264
Fixes #265, Fixes #266, Fixes #267, Fixes #268, Fixes #269

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

apps/orchestrator/src/git/conflict-detection.service.spec.ts

@@ -47,6 +47,7 @@ describe("ConflictDetectionService", () => {
       });
 
       const result = await service.checkForConflicts("/test/repo", {
+        localPath: "/test/repo",
         remote: "origin",
         remoteBranch: "develop",
         strategy: "merge",
@@ -67,9 +68,7 @@ describe("ConflictDetectionService", () => {
       mockGit.revparse.mockResolvedValue("feature-branch");
 
       // Mock merge test - conflicts detected
-      mockGit.raw.mockRejectedValueOnce(
-        new Error("CONFLICT (content): Merge conflict in file.ts"),
-      );
+      mockGit.raw.mockRejectedValueOnce(new Error("CONFLICT (content): Merge conflict in file.ts"));
 
       // Mock status - show conflicted files
       mockGit.status.mockResolvedValue({
@@ -92,6 +91,7 @@ describe("ConflictDetectionService", () => {
       mockGit.raw.mockResolvedValue("");
 
       const result = await service.checkForConflicts("/test/repo", {
+        localPath: "/test/repo",
         remote: "origin",
         remoteBranch: "develop",
         strategy: "merge",
@@ -113,7 +113,7 @@ describe("ConflictDetectionService", () => {
 
       // Mock rebase test - conflicts detected
       mockGit.raw.mockRejectedValueOnce(
-        new Error("CONFLICT (content): Rebase conflict in file.ts"),
+        new Error("CONFLICT (content): Rebase conflict in file.ts")
       );
 
       // Mock status - show conflicted files
@@ -132,6 +132,7 @@ describe("ConflictDetectionService", () => {
       mockGit.raw.mockResolvedValue("");
 
       const result = await service.checkForConflicts("/test/repo", {
+        localPath: "/test/repo",
         remote: "origin",
         remoteBranch: "develop",
         strategy: "rebase",
@@ -148,9 +149,10 @@ describe("ConflictDetectionService", () => {
 
       await expect(
         service.checkForConflicts("/test/repo", {
+          localPath: "/test/repo",
           remote: "origin",
           remoteBranch: "develop",
-        }),
+        })
       ).rejects.toThrow(ConflictDetectionError);
     });
 
@@ -163,7 +165,7 @@ describe("ConflictDetectionService", () => {
 
       // Mock merge test - conflicts detected
       mockGit.raw.mockRejectedValueOnce(
-        new Error("CONFLICT (delete/modify): file.ts deleted in HEAD"),
+        new Error("CONFLICT (delete/modify): file.ts deleted in HEAD")
       );
 
       // Mock status - show conflicted files with delete
@@ -182,6 +184,7 @@ describe("ConflictDetectionService", () => {
       mockGit.raw.mockResolvedValue("");
 
       const result = await service.checkForConflicts("/test/repo", {
+        localPath: "/test/repo",
         remote: "origin",
         remoteBranch: "develop",
         strategy: "merge",
@@ -199,9 +202,7 @@ describe("ConflictDetectionService", () => {
       mockGit.revparse.mockResolvedValue("feature-branch");
 
       // Mock merge test - conflicts detected
-      mockGit.raw.mockRejectedValueOnce(
-        new Error("CONFLICT (add/add): Merge conflict in file.ts"),
-      );
+      mockGit.raw.mockRejectedValueOnce(new Error("CONFLICT (add/add): Merge conflict in file.ts"));
 
       // Mock status - show conflicted files with add
       mockGit.status.mockResolvedValue({
@@ -219,6 +220,7 @@ describe("ConflictDetectionService", () => {
       mockGit.raw.mockResolvedValue("");
 
       const result = await service.checkForConflicts("/test/repo", {
+        localPath: "/test/repo",
         remote: "origin",
         remoteBranch: "develop",
         strategy: "merge",
@@ -280,6 +282,7 @@ describe("ConflictDetectionService", () => {
       });
 
       await service.checkForConflicts("/test/repo", {
+        localPath: "/test/repo",
         strategy: "merge",
       });
 
@@ -300,9 +303,9 @@ describe("ConflictDetectionService", () => {
     it("should throw ConflictDetectionError on fetch failure", async () => {
       mockGit.fetch.mockRejectedValue(new Error("Network error"));
 
-      await expect(
-        service.fetchRemote("/test/repo", "origin", "develop"),
-      ).rejects.toThrow(ConflictDetectionError);
+      await expect(service.fetchRemote("/test/repo", "origin", "develop")).rejects.toThrow(
+        ConflictDetectionError
+      );
     });
 
     it("should use default remote", async () => {
@@ -310,7 +313,7 @@ describe("ConflictDetectionService", () => {
 
       await service.fetchRemote("/test/repo");
 
-      expect(mockGit.fetch).toHaveBeenCalledWith("origin", undefined);
+      expect(mockGit.fetch).toHaveBeenCalledWith("origin");
     });
   });
 
@@ -382,9 +385,7 @@ describe("ConflictDetectionService", () => {
     it("should throw ConflictDetectionError on git status failure", async () => {
       mockGit.status.mockRejectedValue(new Error("Git error"));
 
-      await expect(service.detectConflicts("/test/repo")).rejects.toThrow(
-        ConflictDetectionError,
-      );
+      await expect(service.detectConflicts("/test/repo")).rejects.toThrow(ConflictDetectionError);
     });
   });
 
@@ -395,18 +396,13 @@ describe("ConflictDetectionService", () => {
       const branch = await service.getCurrentBranch("/test/repo");
 
       expect(branch).toBe("feature-branch");
-      expect(mockGit.revparse).toHaveBeenCalledWith([
-        "--abbrev-ref",
-        "HEAD",
-      ]);
+      expect(mockGit.revparse).toHaveBeenCalledWith(["--abbrev-ref", "HEAD"]);
     });
 
     it("should throw ConflictDetectionError on failure", async () => {
       mockGit.revparse.mockRejectedValue(new Error("Not a git repository"));
 
-      await expect(service.getCurrentBranch("/test/repo")).rejects.toThrow(
-        ConflictDetectionError,
-      );
+      await expect(service.getCurrentBranch("/test/repo")).rejects.toThrow(ConflictDetectionError);
     });
   });
 });