fix(orchestrator): resolve all M6 remediation issues (#260-#269)

Addresses all 10 quality remediation issues for the orchestrator module:

TypeScript & Type Safety:
- #260: Fix TypeScript compilation errors in tests
- #261: Replace explicit 'any' types with proper typed mocks

Error Handling & Reliability:
- #262: Fix silent cleanup failures - return structured results
- #263: Fix silent Valkey event parsing failures with proper error handling
- #266: Improve error context in Docker operations
- #267: Fix secret scanner false negatives on file read errors
- #268: Fix worktree cleanup error swallowing

Testing & Quality:
- #264: Add queue integration tests (coverage 15% → 85%)
- #265: Fix Prettier formatting violations
- #269: Update outdated TODO comments

All tests passing (406/406), TypeScript compiles cleanly, ESLint clean.

Fixes #260, Fixes #261, Fixes #262, Fixes #263, Fixes #264
Fixes #265, Fixes #266, Fixes #267, Fixes #268, Fixes #269

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

apps/orchestrator/src/git/git-operations.service.ts

@@ -14,8 +14,7 @@ export class GitOperationsService {
 
   constructor(private readonly configService: ConfigService) {
     this.gitUserName =
-      this.configService.get<string>("orchestrator.git.userName") ??
-      "Mosaic Orchestrator";
+      this.configService.get<string>("orchestrator.git.userName") ?? "Mosaic Orchestrator";
     this.gitUserEmail =
       this.configService.get<string>("orchestrator.git.userEmail") ??
       "orchestrator@mosaicstack.dev";
@@ -31,11 +30,7 @@ export class GitOperationsService {
   /**
    * Clone a repository
    */
-  async cloneRepository(
-    url: string,
-    localPath: string,
-    branch?: string,
-  ): Promise<void> {
+  async cloneRepository(url: string, localPath: string, branch?: string): Promise<void> {
     try {
       this.logger.log(`Cloning repository ${url} to ${localPath}`);
       const git = simpleGit();
@@ -48,11 +43,11 @@ export class GitOperationsService {
 
       this.logger.log(`Successfully cloned repository to ${localPath}`);
     } catch (error) {
-      this.logger.error(`Failed to clone repository: ${error}`);
+      this.logger.error(`Failed to clone repository: ${String(error)}`);
       throw new GitOperationError(
         `Failed to clone repository from ${url}`,
         "clone",
-        error as Error,
+        error as Error
       );
     }
   }
@@ -69,11 +64,11 @@ export class GitOperationsService {
 
       this.logger.log(`Successfully created branch ${branchName}`);
     } catch (error) {
-      this.logger.error(`Failed to create branch: ${error}`);
+      this.logger.error(`Failed to create branch: ${String(error)}`);
       throw new GitOperationError(
         `Failed to create branch ${branchName}`,
         "createBranch",
-        error as Error,
+        error as Error
       );
     }
   }
@@ -81,11 +76,7 @@ export class GitOperationsService {
   /**
    * Commit changes
    */
-  async commit(
-    localPath: string,
-    message: string,
-    files?: string[],
-  ): Promise<void> {
+  async commit(localPath: string, message: string, files?: string[]): Promise<void> {
     try {
       this.logger.log(`Committing changes at ${localPath}`);
       const git = this.getGit(localPath);
@@ -106,24 +97,15 @@ export class GitOperationsService {
 
       this.logger.log(`Successfully committed changes: ${message}`);
     } catch (error) {
-      this.logger.error(`Failed to commit: ${error}`);
-      throw new GitOperationError(
-        `Failed to commit changes`,
-        "commit",
-        error as Error,
-      );
+      this.logger.error(`Failed to commit: ${String(error)}`);
+      throw new GitOperationError(`Failed to commit changes`, "commit", error as Error);
     }
   }
 
   /**
    * Push changes to remote
    */
-  async push(
-    localPath: string,
-    remote: string = "origin",
-    branch?: string,
-    force: boolean = false,
-  ): Promise<void> {
+  async push(localPath: string, remote = "origin", branch?: string, force = false): Promise<void> {
     try {
       this.logger.log(`Pushing changes from ${localPath} to ${remote}`);
       const git = this.getGit(localPath);
@@ -136,12 +118,8 @@ export class GitOperationsService {
 
       this.logger.log(`Successfully pushed changes to ${remote}`);
     } catch (error) {
-      this.logger.error(`Failed to push: ${error}`);
-      throw new GitOperationError(
-        `Failed to push changes to ${remote}`,
-        "push",
-        error as Error,
-      );
+      this.logger.error(`Failed to push: ${String(error)}`);
+      throw new GitOperationError(`Failed to push changes to ${remote}`, "push", error as Error);
     }
   }
 }