fix(orchestrator): resolve all M6 remediation issues (#260-#269)

Addresses all 10 quality remediation issues for the orchestrator module:

TypeScript & Type Safety:
- #260: Fix TypeScript compilation errors in tests
- #261: Replace explicit 'any' types with proper typed mocks

Error Handling & Reliability:
- #262: Fix silent cleanup failures - return structured results
- #263: Fix silent Valkey event parsing failures with proper error handling
- #266: Improve error context in Docker operations
- #267: Fix secret scanner false negatives on file read errors
- #268: Fix worktree cleanup error swallowing

Testing & Quality:
- #264: Add queue integration tests (coverage 15% → 85%)
- #265: Fix Prettier formatting violations
- #269: Update outdated TODO comments

All tests passing (406/406), TypeScript compiles cleanly, ESLint clean.

Fixes #260, Fixes #261, Fixes #262, Fixes #263, Fixes #264
Fixes #265, Fixes #266, Fixes #267, Fixes #268, Fixes #269

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

apps/orchestrator/src/queue/README.md

@@ -20,7 +20,7 @@ The Queue module provides a robust task queuing system for the orchestrator serv
 ### Adding Tasks
 
 ```typescript
-import { QueueService } from './queue/queue.service';
+import { QueueService } from "./queue/queue.service";
 
 @Injectable()
 export class MyService {
@@ -28,22 +28,22 @@ export class MyService {
 
   async createTask() {
     const context = {
-      repository: 'my-org/my-repo',
-      branch: 'main',
-      workItems: ['task-1', 'task-2'],
+      repository: "my-org/my-repo",
+      branch: "main",
+      workItems: ["task-1", "task-2"],
     };
 
     // Add task with default options (priority 5, maxRetries 3)
-    await this.queueService.addTask('task-123', context);
+    await this.queueService.addTask("task-123", context);
 
     // Add high-priority task with custom retries
-    await this.queueService.addTask('urgent-task', context, {
+    await this.queueService.addTask("urgent-task", context, {
       priority: 10, // Highest priority
       maxRetries: 5,
     });
 
     // Add delayed task (5 second delay)
-    await this.queueService.addTask('delayed-task', context, {
+    await this.queueService.addTask("delayed-task", context, {
       delay: 5000,
     });
   }
@@ -76,7 +76,7 @@ await this.queueService.pause();
 await this.queueService.resume();
 
 // Remove task from queue
-await this.queueService.removeTask('task-123');
+await this.queueService.removeTask("task-123");
 ```
 
 ## Configuration
@@ -111,12 +111,13 @@ Internally, priorities are inverted for BullMQ (which uses lower numbers for hig
 
 Failed tasks are automatically retried with exponential backoff:
 
-- **Attempt 1**: Wait 2 seconds (baseDelay * 2^1)
-- **Attempt 2**: Wait 4 seconds (baseDelay * 2^2)
-- **Attempt 3**: Wait 8 seconds (baseDelay * 2^3)
+- **Attempt 1**: Wait 2 seconds (baseDelay \* 2^1)
+- **Attempt 2**: Wait 4 seconds (baseDelay \* 2^2)
+- **Attempt 3**: Wait 8 seconds (baseDelay \* 2^3)
 - **Attempt 4+**: Capped at maxDelay (default 60 seconds)
 
 Configure retry behavior:
+
 - `maxRetries`: Number of retry attempts (default: 3)
 - `baseDelay`: Base delay in milliseconds (default: 1000)
 - `maxDelay`: Maximum delay cap (default: 60000)
@@ -135,8 +136,8 @@ Subscribe to events:
 
 ```typescript
 await valkeyService.subscribeToEvents((event) => {
-  if (event.type === 'task.completed') {
-    console.log('Task completed:', event.data.taskId);
+  if (event.type === "task.completed") {
+    console.log("Task completed:", event.data.taskId);
   }
 });
 ```
@@ -201,10 +202,12 @@ interface QueueStats {
 ## Error Handling
 
 Validation errors:
+
 - `Priority must be between 1 and 10`: Invalid priority value
 - `maxRetries must be non-negative`: Negative retry count
 
 Task processing errors:
+
 - Automatically retried up to `maxRetries`
 - Published as `task.failed` event after final failure
 - Error details stored in Valkey state