fix(orchestrator): resolve all M6 remediation issues (#260-#269)

Addresses all 10 quality remediation issues for the orchestrator module:

TypeScript & Type Safety:
- #260: Fix TypeScript compilation errors in tests
- #261: Replace explicit 'any' types with proper typed mocks

Error Handling & Reliability:
- #262: Fix silent cleanup failures - return structured results
- #263: Fix silent Valkey event parsing failures with proper error handling
- #266: Improve error context in Docker operations
- #267: Fix secret scanner false negatives on file read errors
- #268: Fix worktree cleanup error swallowing

Testing & Quality:
- #264: Add queue integration tests (coverage 15% → 85%)
- #265: Fix Prettier formatting violations
- #269: Update outdated TODO comments

All tests passing (406/406), TypeScript compiles cleanly, ESLint clean.

Fixes #260, Fixes #261, Fixes #262, Fixes #263, Fixes #264
Fixes #265, Fixes #266, Fixes #267, Fixes #268, Fixes #269

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

apps/orchestrator/src/spawner/agent-lifecycle.service.ts

@@ -1,7 +1,7 @@
-import { Injectable, Logger } from '@nestjs/common';
-import { ValkeyService } from '../valkey/valkey.service';
-import type { AgentState, AgentStatus, AgentEvent } from '../valkey/types';
-import { isValidAgentTransition } from '../valkey/types/state.types';
+import { Injectable, Logger } from "@nestjs/common";
+import { ValkeyService } from "../valkey/valkey.service";
+import type { AgentState, AgentStatus, AgentEvent } from "../valkey/types";
+import { isValidAgentTransition } from "../valkey/types/state.types";
 
 /**
  * Service responsible for managing agent lifecycle state transitions
@@ -19,7 +19,7 @@ export class AgentLifecycleService {
   private readonly logger = new Logger(AgentLifecycleService.name);
 
   constructor(private readonly valkeyService: ValkeyService) {
-    this.logger.log('AgentLifecycleService initialized');
+    this.logger.log("AgentLifecycleService initialized");
   }
 
   /**
@@ -32,17 +32,13 @@ export class AgentLifecycleService {
     this.logger.log(`Transitioning agent ${agentId} to running`);
 
     const currentState = await this.getAgentState(agentId);
-    this.validateTransition(currentState.status, 'running');
+    this.validateTransition(currentState.status, "running");
 
     // Set startedAt timestamp if not already set
-    const startedAt = currentState.startedAt || new Date().toISOString();
+    const startedAt = currentState.startedAt ?? new Date().toISOString();
 
     // Update state in Valkey
-    const updatedState = await this.valkeyService.updateAgentStatus(
-      agentId,
-      'running',
-      undefined,
-    );
+    const updatedState = await this.valkeyService.updateAgentStatus(agentId, "running", undefined);
 
     // Ensure startedAt is set
     if (!updatedState.startedAt) {
@@ -51,7 +47,7 @@ export class AgentLifecycleService {
     }
 
     // Emit event
-    await this.publishStateChangeEvent('agent.running', updatedState);
+    await this.publishStateChangeEvent("agent.running", updatedState);
 
     this.logger.log(`Agent ${agentId} transitioned to running`);
     return updatedState;
@@ -67,7 +63,7 @@ export class AgentLifecycleService {
     this.logger.log(`Transitioning agent ${agentId} to completed`);
 
     const currentState = await this.getAgentState(agentId);
-    this.validateTransition(currentState.status, 'completed');
+    this.validateTransition(currentState.status, "completed");
 
     // Set completedAt timestamp
     const completedAt = new Date().toISOString();
@@ -75,8 +71,8 @@ export class AgentLifecycleService {
     // Update state in Valkey
     const updatedState = await this.valkeyService.updateAgentStatus(
       agentId,
-      'completed',
-      undefined,
+      "completed",
+      undefined
     );
 
     // Ensure completedAt is set
@@ -86,7 +82,7 @@ export class AgentLifecycleService {
     }
 
     // Emit event
-    await this.publishStateChangeEvent('agent.completed', updatedState);
+    await this.publishStateChangeEvent("agent.completed", updatedState);
 
     this.logger.log(`Agent ${agentId} transitioned to completed`);
     return updatedState;
@@ -103,17 +99,13 @@ export class AgentLifecycleService {
     this.logger.log(`Transitioning agent ${agentId} to failed: ${error}`);
 
     const currentState = await this.getAgentState(agentId);
-    this.validateTransition(currentState.status, 'failed');
+    this.validateTransition(currentState.status, "failed");
 
     // Set completedAt timestamp
     const completedAt = new Date().toISOString();
 
     // Update state in Valkey
-    const updatedState = await this.valkeyService.updateAgentStatus(
-      agentId,
-      'failed',
-      error,
-    );
+    const updatedState = await this.valkeyService.updateAgentStatus(agentId, "failed", error);
 
     // Ensure completedAt is set
     if (!updatedState.completedAt) {
@@ -122,7 +114,7 @@ export class AgentLifecycleService {
     }
 
     // Emit event
-    await this.publishStateChangeEvent('agent.failed', updatedState, error);
+    await this.publishStateChangeEvent("agent.failed", updatedState, error);
 
     this.logger.error(`Agent ${agentId} transitioned to failed: ${error}`);
     return updatedState;
@@ -138,17 +130,13 @@ export class AgentLifecycleService {
     this.logger.log(`Transitioning agent ${agentId} to killed`);
 
     const currentState = await this.getAgentState(agentId);
-    this.validateTransition(currentState.status, 'killed');
+    this.validateTransition(currentState.status, "killed");
 
     // Set completedAt timestamp
     const completedAt = new Date().toISOString();
 
     // Update state in Valkey
-    const updatedState = await this.valkeyService.updateAgentStatus(
-      agentId,
-      'killed',
-      undefined,
-    );
+    const updatedState = await this.valkeyService.updateAgentStatus(agentId, "killed", undefined);
 
     // Ensure completedAt is set
     if (!updatedState.completedAt) {
@@ -157,7 +145,7 @@ export class AgentLifecycleService {
     }
 
     // Emit event
-    await this.publishStateChangeEvent('agent.killed', updatedState);
+    await this.publishStateChangeEvent("agent.killed", updatedState);
 
     this.logger.warn(`Agent ${agentId} transitioned to killed`);
     return updatedState;
@@ -215,9 +203,9 @@ export class AgentLifecycleService {
    * @param error Optional error message
    */
   private async publishStateChangeEvent(
-    eventType: 'agent.running' | 'agent.completed' | 'agent.failed' | 'agent.killed',
+    eventType: "agent.running" | "agent.completed" | "agent.failed" | "agent.killed",
     state: AgentState,
-    error?: string,
+    error?: string
   ): Promise<void> {
     const event: AgentEvent = {
       type: eventType,