fix(orchestrator): resolve all M6 remediation issues (#260-#269)

Addresses all 10 quality remediation issues for the orchestrator module:

TypeScript & Type Safety:
- #260: Fix TypeScript compilation errors in tests
- #261: Replace explicit 'any' types with proper typed mocks

Error Handling & Reliability:
- #262: Fix silent cleanup failures - return structured results
- #263: Fix silent Valkey event parsing failures with proper error handling
- #266: Improve error context in Docker operations
- #267: Fix secret scanner false negatives on file read errors
- #268: Fix worktree cleanup error swallowing

Testing & Quality:
- #264: Add queue integration tests (coverage 15% → 85%)
- #265: Fix Prettier formatting violations
- #269: Update outdated TODO comments

All tests passing (406/406), TypeScript compiles cleanly, ESLint clean.

Fixes #260, Fixes #261, Fixes #262, Fixes #263, Fixes #264
Fixes #265, Fixes #266, Fixes #267, Fixes #268, Fixes #269

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

apps/orchestrator/src/valkey/valkey.service.ts

@@ -1,6 +1,6 @@
-import { Injectable, OnModuleDestroy } from '@nestjs/common';
-import { ConfigService } from '@nestjs/config';
-import { ValkeyClient, ValkeyClientConfig } from './valkey.client';
+import { Injectable, OnModuleDestroy, Logger } from "@nestjs/common";
+import { ConfigService } from "@nestjs/config";
+import { ValkeyClient, ValkeyClientConfig, EventErrorHandler } from "./valkey.client";
 import type {
   TaskState,
   AgentState,
@@ -9,7 +9,7 @@ import type {
   OrchestratorEvent,
   EventHandler,
   TaskContext,
-} from './types';
+} from "./types";
 
 /**
  * NestJS service for Valkey state management and pub/sub
@@ -17,14 +17,20 @@ import type {
 @Injectable()
 export class ValkeyService implements OnModuleDestroy {
   private readonly client: ValkeyClient;
+  private readonly logger = new Logger(ValkeyService.name);
 
   constructor(private readonly configService: ConfigService) {
     const config: ValkeyClientConfig = {
-      host: this.configService.get<string>('orchestrator.valkey.host', 'localhost'),
-      port: this.configService.get<number>('orchestrator.valkey.port', 6379),
+      host: this.configService.get<string>("orchestrator.valkey.host", "localhost"),
+      port: this.configService.get<number>("orchestrator.valkey.port", 6379),
+      logger: {
+        error: (message: string, error?: unknown) => {
+          this.logger.error(message, error instanceof Error ? error.stack : String(error));
+        },
+      },
     };
 
-    const password = this.configService.get<string>('orchestrator.valkey.password');
+    const password = this.configService.get<string>("orchestrator.valkey.password");
     if (password) {
       config.password = password;
     }
@@ -101,8 +107,8 @@ export class ValkeyService implements OnModuleDestroy {
     return this.client.publishEvent(event);
   }
 
-  async subscribeToEvents(handler: EventHandler): Promise<void> {
-    return this.client.subscribeToEvents(handler);
+  async subscribeToEvents(handler: EventHandler, errorHandler?: EventErrorHandler): Promise<void> {
+    return this.client.subscribeToEvents(handler, errorHandler);
   }
 
   /**
@@ -113,7 +119,7 @@ export class ValkeyService implements OnModuleDestroy {
     const now = new Date().toISOString();
     const state: TaskState = {
       taskId,
-      status: 'pending',
+      status: "pending",
       context,
       createdAt: now,
       updatedAt: now,
@@ -124,7 +130,7 @@ export class ValkeyService implements OnModuleDestroy {
   async createAgent(agentId: string, taskId: string): Promise<void> {
     const state: AgentState = {
       agentId,
-      status: 'spawning',
+      status: "spawning",
       taskId,
     };
     await this.setAgentState(state);