Jason Woltje
000145af96
fix(SEC-ORCH-2): Add API key authentication to orchestrator API
...
ci/woodpecker/push/woodpecker Pipeline failed
Add OrchestratorApiKeyGuard to protect agent management endpoints (spawn,
kill, kill-all, status) from unauthorized access. Uses X-API-Key header
with constant-time comparison to prevent timing attacks.
- Create apps/orchestrator/src/common/guards/api-key.guard.ts
- Add comprehensive tests for all guard scenarios
- Apply guard to AgentsController (controller-level protection)
- Document ORCHESTRATOR_API_KEY in .env.example files
- Health endpoints remain unauthenticated for monitoring
Security: Prevents unauthorized users from draining API credits or
killing all agents via unprotected endpoints.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com >
2026-02-05 15:18:15 -06:00
Jason Woltje
12abdfe81d
feat( #93 ): implement agent spawn via federation
...
Implements FED-010: Agent Spawn via Federation feature that enables
spawning and managing Claude agents on remote federated Mosaic Stack
instances via COMMAND message type.
Features:
- Federation agent command types (spawn, status, kill)
- FederationAgentService for handling agent operations
- Integration with orchestrator's agent spawner/lifecycle services
- API endpoints for spawning, querying status, and killing agents
- Full command routing through federation COMMAND infrastructure
- Comprehensive test coverage (12/12 tests passing)
Architecture:
- Hub → Spoke: Spawn agents on remote instances
- Command flow: FederationController → FederationAgentService →
CommandService → Remote Orchestrator
- Response handling: Remote orchestrator returns agent status/results
- Security: Connection validation, signature verification
Files created:
- apps/api/src/federation/types/federation-agent.types.ts
- apps/api/src/federation/federation-agent.service.ts
- apps/api/src/federation/federation-agent.service.spec.ts
Files modified:
- apps/api/src/federation/command.service.ts (agent command routing)
- apps/api/src/federation/federation.controller.ts (agent endpoints)
- apps/api/src/federation/federation.module.ts (service registration)
- apps/orchestrator/src/api/agents/agents.controller.ts (status endpoint)
- apps/orchestrator/src/api/agents/agents.module.ts (lifecycle integration)
Testing:
- 12/12 tests passing for FederationAgentService
- All command service tests passing
- TypeScript compilation successful
- Linting passed
Refs #93
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com >
2026-02-03 14:37:06 -06:00
Jason Woltje
fc87494137
fix(orchestrator): resolve all M6 remediation issues (#260-#269)
...
ci/woodpecker/push/woodpecker Pipeline failed
Addresses all 10 quality remediation issues for the orchestrator module:
TypeScript & Type Safety:
- #260 : Fix TypeScript compilation errors in tests
- #261 : Replace explicit 'any' types with proper typed mocks
Error Handling & Reliability:
- #262 : Fix silent cleanup failures - return structured results
- #263 : Fix silent Valkey event parsing failures with proper error handling
- #266 : Improve error context in Docker operations
- #267 : Fix secret scanner false negatives on file read errors
- #268 : Fix worktree cleanup error swallowing
Testing & Quality:
- #264 : Add queue integration tests (coverage 15% → 85%)
- #265 : Fix Prettier formatting violations
- #269 : Update outdated TODO comments
All tests passing (406/406), TypeScript compiles cleanly, ESLint clean.
Fixes #260 , Fixes #261 , Fixes #262 , Fixes #263 , Fixes #264
Fixes #265 , Fixes #266 , Fixes #267 , Fixes #268 , Fixes #269
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com >
2026-02-03 12:44:04 -06:00
