launchpad: row 301 (#1808): library-cli and thread-claims bus.mjs fixtures export throwing busBusiness and userCaller stubs (mos-1451 under mos-1272); BUILD.md repaired with run 1 and the ruling; manifest seven paths; unrun

agents/launchpad/work/queue-301/BUILD.md

@@ -0,0 +1,67 @@
+# Row 301 build notes (Launchpad): R6-N4, fold user-bus.mjs back into bus.mjs (#1808)
+
+Brief: docs/plans/2026-10-23_r6-followup-rows.md § Brief: R6-N4. Reviewer Duckworth, gate owner Sage.
+Base e551cd846 (refactor after row 303). Branch launchpad/row301.
+
+## Change
+
+- packages/webui/src/bus.mjs: the user transport moves in beside humanCall, after `busReader`:
+  `USER_CLI`, `userCall`, `busBusiness` and `userCaller`, byte for byte from user-bus.mjs (checked
+  with diff), under a three-line header. One import is added, `fileURLToPath` from node:url.
+  `readHostState`, `spawn`, `randomBytes` and `BusReadError` were already in bus.mjs. humanCall and
+  busCaller are untouched.
+- packages/webui/src/user-bus.mjs: deleted.
+- packages/webui/src/cli.mjs: the two imports become one, from './bus.mjs'.
+- packages/webui/src/console-bus.mjs: a comment names bus.mjs instead of user-bus.mjs.
+- packages/webui/tests/granted-user.test.mjs:22-23: the two imports become one, from '../src/bus.mjs'.
+  Only the import path changes. Mos ruled (mos-1449, via sage-3399) that this is covered by "update
+  its imports" and is not an old-test change.
+
+No other reference to user-bus.mjs remains under packages/. tools/agent-watch's "user-bus" means
+something unrelated. The 294 packet's mutants name the old file as history only.
+
+## Re-pin
+
+channel-proof.test.mjs:28 pinned packages/webui/src/bus.mjs at 15e8123f…3313. After the fold the
+file hashes to 39fcb27c82e917ef05e1a7a650d522c9f3c656bf8dbade87b8ddb3661b67ad6c. A pin change is an
+old-test change. Mos approved it under mos-1272 in mos-1449 (via sage-3399), as its own commit, with
+row 301 making its own re-pin window. Mos checked fd4b8c36e read-only: bus.mjs hashes to 39fcb27c,
+its diff removes no lines, user-bus.mjs from `export const USER_CLI` to the end is in it byte for
+byte, and nothing else imports user-bus.mjs. The second commit changes that one value and adds one
+comment line in the row 165/171/194 style.
+
+## Gate
+
+Duckworth approves the manifest. channel-proof.test, the webui suite and the 294 user-transport
+tests (granted-user.test.mjs) run whole and green, on Sage's CLEAR.
+
+MANIFEST.sha256 lists the changed paths. DELETED.txt names the one removed path.
+
+## Run 1 (sage-3408 CLEAR, 12:08Z, head 04a179740)
+
+npm ci root and webui green. channel-proof.test whole 2 pass 0 fail. The webui suite whole went
+374 tests, 372 pass, 2 fail, 0 skipped, so the gate stopped. granted-user.test whole, run after the
+stop to see whether the stop hid another red: 19 pass 0 fail. No file changed.
+
+Both reds were in old tests: library-cli.test.mjs:10 (C2-04) and thread-claims.test.mjs:54 (row278
+Console adapter). Each failed with `SyntaxError: The requested module './bus.mjs' does not provide an
+export named 'busBusiness'` at cli.mjs:5. Each test spawns cli.mjs with a registerHooks load hook
+that replaces /webui/src/bus.mjs with a fixture exporting only BusReadError and busCaller. Before
+the fold, cli.mjs took busBusiness and userCaller from the real user-bus.mjs. Now they come from the
+stubbed bus.mjs, so cli.mjs fails to link. cli.mjs calls them only under --sso (:98, :103), and
+neither test passes --sso. A URL-keyed stub is not an import, so the "nothing else imports
+user-bus.mjs" check and the static reviews missed it. `git grep "webui/src/bus.mjs" --
+'packages/*/tests/*'` finds exactly channel-proof, library-cli and thread-claims.
+
+## Fixture change (mos-1451 under mos-1272, via sage-3418)
+
+Mos approved option A with one change and refused option B, a namespace import in cli.mjs. Each
+of the two busSource template strings (library-cli.test.mjs:17, thread-claims.test.mjs:58) gets
+this appended, and nothing else changes in either file:
+
+    export const busBusiness=()=>{throw Error('busBusiness outside --sso')};export const userCaller=()=>{throw Error('userCaller outside --sso')};
+
+The stubs throw rather than return null, so a test that reaches them outside --sso fails loudly.
+The text has no backtick, `${` or backslash, so the template literal carries it unchanged. The
+manifest goes from five paths to seven. Sage's gate: webui 374/0, channel-proof 2/0,
+granted-user 19/0. Any other red stops the gate and goes to Mos.

agents/launchpad/work/queue-301/DELETED.txt

@@ -0,0 +1 @@
+deleted  packages/webui/src/user-bus.mjs

agents/launchpad/work/queue-301/MANIFEST.sha256

@@ -0,0 +1,7 @@
+db1f05e312b9bee7ece7df7df78047a2965024109a297cb8a24112135a6e5f04  packages/bus/tests/channel-proof.test.mjs
+39fcb27c82e917ef05e1a7a650d522c9f3c656bf8dbade87b8ddb3661b67ad6c  packages/webui/src/bus.mjs
+0862b2b5bf6511d2c5deca1f318eee643edaee489c0ce8c83e57364f2f54a3d8  packages/webui/src/cli.mjs
+653d2087c0796a35c3884b7243d1adf8a78c52950a4924049317063f2d3c0974  packages/webui/src/console-bus.mjs
+34b6d052855369c8f7cf1faf8bab3c59ddf96ccd4c42731bd86a4e61e5e70640  packages/webui/tests/granted-user.test.mjs
+7e782c2b6b46b6b8b6e58cd3d148bf041d49e8fbf2cbbed51080cdb02fc11d89  packages/webui/tests/library-cli.test.mjs
+dd1e62d14a59bb8fe7cd4654dd1de8e518270c36d104ee356e165faee7f95a02  packages/webui/tests/thread-claims.test.mjs

packages/bus/tests/channel-proof.test.mjs

@@ -25,7 +25,8 @@ const baselines = {
  // Row 171 (#1668): project-name-is-repo maps to 409; no proof or transport change.
  // Row 194 (#1692, brief item 7, sage-1610 a): organization-tracker-required 400 and
  // organization-tracker-bot-taken 409; no proof or transport change.
- "packages/webui/src/bus.mjs": "15e8123ffdbb6d067e8a516f5823efdb5de3c869963764f27cd14bb9e4ce3313",
+ // Row 301 (#1808, mos-1449): the user transport moved from user-bus.mjs into bus.mjs; humanCall unchanged.
+ "packages/webui/src/bus.mjs": "39fcb27c82e917ef05e1a7a650d522c9f3c656bf8dbade87b8ddb3661b67ad6c",
 };
 const repoFile = path => new URL("../../../" + path, import.meta.url);
 

packages/webui/src/bus.mjs

@@ -10,6 +10,7 @@
 
 import { spawn } from 'node:child_process';
 import { randomBytes } from 'node:crypto';
+import { fileURLToPath } from 'node:url';
 import { HUMAN_CLI } from '../../cli/src/transport.mjs';
 import { readHostState } from '../../cli/src/host.mjs';
 import { views } from '../../bus/src/views.mjs';
@@ -72,6 +73,63 @@ export function busCaller({ dataRoot, socket, business = null, env = process.env
 }
 export const busReader = options => views({ call: busCaller(options) });
 
+// FED R6 (#1800): a granted user's bus transport, R3's user-cli.mjs (#414, design 3.6). Same
+// protocol as humanCall: the request on stdin, JSON on stdout, or a bus error code as the last
+// `^[a-z-]{1,64}$` line of stderr. Row 301 (#1808) moved it here from user-bus.mjs.
+export const USER_CLI = fileURLToPath(new URL('../../bus/src/user-cli.mjs', import.meta.url));
+
+// The Console sets the user nonce itself, so user-cli.mjs doesn't re-exec and the broker sees the
+// Console (`cli.mjs serve`) as its parent (principal.mjs). The human nonce is dropped, so this child
+// can never pass as human-cli, and it only ever runs USER_CLI.
+export function userCall({ socket, business, user, env = process.env, timeoutMs = 30000, maxBytes = 8 * 1024 * 1024 }) {
+  const { MOSAIC_BUS_CLI_NONCE, ...rest } = env;
+  return (verb, args = {}) => new Promise((resolve, reject) => {
+    let child;
+    try {
+      child = spawn(process.execPath, [USER_CLI, socket], { env: { ...rest, MOSAIC_BUS_USER_NONCE: randomBytes(32).toString('hex') }, stdio: ['pipe', 'pipe', 'pipe'] });
+    } catch { return reject(new BusReadError('outcome-unknown', 'the bus transport did not start')); }
+    const out = [], err = [];
+    let size = 0, settled = false;
+    const done = (fn, value) => { if (!settled) { settled = true; clearTimeout(timer); fn(value); } };
+    const timer = setTimeout(() => { child.kill('SIGKILL'); done(reject, new BusReadError('outcome-unknown', 'the bus transport did not finish in time')); }, timeoutMs);
+    child.stdout.on('data', chunk => {
+      size += chunk.length;
+      if (size > maxBytes) { child.kill('SIGKILL'); return done(reject, new BusReadError('response-too-large')); }
+      out.push(chunk);
+    });
+    child.stderr.on('data', chunk => { if (err.length < 64) err.push(chunk); });
+    child.on('error', () => done(reject, new BusReadError('outcome-unknown', 'the bus transport did not start')));
+    child.on('close', status => {
+      if (status === null) return done(reject, new BusReadError('outcome-unknown', 'the bus transport did not finish'));
+      if (status !== 0) {
+        const code = Buffer.concat(err).toString('utf8').trim().split('\n').reverse().find(l => /^[a-z-]{1,64}$/.test(l)) ?? 'invalid-response';
+        return done(reject, new BusReadError(code));
+      }
+      try { done(resolve, JSON.parse(Buffer.concat(out).toString('utf8'))); }
+      catch { done(reject, new BusReadError('invalid-response')); }
+    });
+    child.stdin.on('error', () => {}); // A child that exits early reports through 'close'.
+    child.stdin.end(`${JSON.stringify({ business, user, verb, args })}\n`);
+  });
+}
+
+// The business is the --business flag, or else the live bus host's, read on every call, as busCaller does.
+export function busBusiness({ dataRoot, business = null }) {
+  return () => {
+    if (business) return business;
+    let state;
+    try { state = readHostState(dataRoot); } catch { throw new BusReadError('no-bus-host', 'the bus host state file is unreadable'); }
+    if (!state?.live) throw new BusReadError('no-bus-host', 'no bus host is running and no --business was given');
+    return state.business;
+  };
+}
+
+// One granted user's caller, for that user's session only.
+export function userCaller({ dataRoot, socket, business = null, user, env = process.env, timeoutMs = 30000 }) {
+  const which = busBusiness({ dataRoot, business });
+  return async (verb, args) => userCall({ socket, business: which(), user, env, timeoutMs })(verb, args);
+}
+
 // A send's error, sorted. The broker writes in one transaction, so any code it
 // returns means nothing was written. A transport that lost the answer, or an
 // answer that can't be read, leaves the outcome open: the message may exist.

packages/webui/src/cli.mjs

@@ -2,8 +2,7 @@
 // MOSAIC_TESTER_SOCKET_V1: private tester ingress, no tester TCP.
 import { createChat } from './chat.mjs';
 import { startServer, previewOptions, proofOptions, DEFAULT_BOARD } from './serve.mjs';
-import { busCaller } from './bus.mjs';
-import { busBusiness, userCaller } from './user-bus.mjs';
+import { busCaller, busBusiness, userCaller } from './bus.mjs';
 import { consoleBus, userOptionsFor, agentCaller, TESTER_AGENT_VERBS } from './console-bus.mjs';
 import { consoleAccess } from './access.mjs';
 import { accessContextFor } from '../../cli/src/access.mjs';

packages/webui/src/console-bus.mjs

@@ -1,6 +1,6 @@
 // FED R6 (#1800): the Console's bus-backed options for startServer, built over one transport
 // `call`. cli.mjs builds them once over the human transport. A granted user's session gets the same
-// set over its own user transport (user-bus.mjs userCaller), so no route a user reaches holds a
+// set over its own user transport (bus.mjs userCaller), so no route a user reaches holds a
 // human-transport object, and the broker decides every verb the user sends (design 3.1 D4).
 import { createChat } from './chat.mjs';
 import { views } from '../../bus/src/views.mjs';

packages/webui/src/user-bus.mjs

@@ -1,63 +0,0 @@
-// FED R6 (#1800): a granted user's bus transport, R3's user-cli.mjs (#414, design 3.6). Kept apart
-// from bus.mjs so the human transport's reviewed bytes stay as row 164 froze them
-// (bus/tests/channel-proof.test.mjs). Same protocol as humanCall: the request on stdin, JSON on
-// stdout, or a bus error code as the last `^[a-z-]{1,64}$` line of stderr.
-import { spawn } from 'node:child_process';
-import { randomBytes } from 'node:crypto';
-import { fileURLToPath } from 'node:url';
-import { readHostState } from '../../cli/src/host.mjs';
-import { BusReadError } from './bus.mjs';
-
-export const USER_CLI = fileURLToPath(new URL('../../bus/src/user-cli.mjs', import.meta.url));
-
-// The Console sets the user nonce itself, so user-cli.mjs doesn't re-exec and the broker sees the
-// Console (`cli.mjs serve`) as its parent (principal.mjs). The human nonce is dropped, so this child
-// can never pass as human-cli, and it only ever runs USER_CLI.
-export function userCall({ socket, business, user, env = process.env, timeoutMs = 30000, maxBytes = 8 * 1024 * 1024 }) {
-  const { MOSAIC_BUS_CLI_NONCE, ...rest } = env;
-  return (verb, args = {}) => new Promise((resolve, reject) => {
-    let child;
-    try {
-      child = spawn(process.execPath, [USER_CLI, socket], { env: { ...rest, MOSAIC_BUS_USER_NONCE: randomBytes(32).toString('hex') }, stdio: ['pipe', 'pipe', 'pipe'] });
-    } catch { return reject(new BusReadError('outcome-unknown', 'the bus transport did not start')); }
-    const out = [], err = [];
-    let size = 0, settled = false;
-    const done = (fn, value) => { if (!settled) { settled = true; clearTimeout(timer); fn(value); } };
-    const timer = setTimeout(() => { child.kill('SIGKILL'); done(reject, new BusReadError('outcome-unknown', 'the bus transport did not finish in time')); }, timeoutMs);
-    child.stdout.on('data', chunk => {
-      size += chunk.length;
-      if (size > maxBytes) { child.kill('SIGKILL'); return done(reject, new BusReadError('response-too-large')); }
-      out.push(chunk);
-    });
-    child.stderr.on('data', chunk => { if (err.length < 64) err.push(chunk); });
-    child.on('error', () => done(reject, new BusReadError('outcome-unknown', 'the bus transport did not start')));
-    child.on('close', status => {
-      if (status === null) return done(reject, new BusReadError('outcome-unknown', 'the bus transport did not finish'));
-      if (status !== 0) {
-        const code = Buffer.concat(err).toString('utf8').trim().split('\n').reverse().find(l => /^[a-z-]{1,64}$/.test(l)) ?? 'invalid-response';
-        return done(reject, new BusReadError(code));
-      }
-      try { done(resolve, JSON.parse(Buffer.concat(out).toString('utf8'))); }
-      catch { done(reject, new BusReadError('invalid-response')); }
-    });
-    child.stdin.on('error', () => {}); // A child that exits early reports through 'close'.
-    child.stdin.end(`${JSON.stringify({ business, user, verb, args })}\n`);
-  });
-}
-
-// The business is the --business flag, or else the live bus host's, read on every call, as busCaller does.
-export function busBusiness({ dataRoot, business = null }) {
-  return () => {
-    if (business) return business;
-    let state;
-    try { state = readHostState(dataRoot); } catch { throw new BusReadError('no-bus-host', 'the bus host state file is unreadable'); }
-    if (!state?.live) throw new BusReadError('no-bus-host', 'no bus host is running and no --business was given');
-    return state.business;
-  };
-}
-
-// One granted user's caller, for that user's session only.
-export function userCaller({ dataRoot, socket, business = null, user, env = process.env, timeoutMs = 30000 }) {
-  const which = busBusiness({ dataRoot, business });
-  return async (verb, args) => userCall({ socket, business: which(), user, env, timeoutMs })(verb, args);
-}

packages/webui/tests/granted-user.test.mjs

@@ -19,8 +19,7 @@ import { startServer, userRoute } from '../src/serve.mjs';
 import { createSso, SESSION_COOKIE } from '../src/sso.mjs';
 import { consoleAccess } from '../src/access.mjs';
 import { consoleBus, userOptionsFor } from '../src/console-bus.mjs';
-import { BusReadError } from '../src/bus.mjs';
-import { USER_CLI, userCall } from '../src/user-bus.mjs';
+import { BusReadError, USER_CLI, userCall } from '../src/bus.mjs';
 import { close, fixture } from './fixture.mjs';
 import { browser } from './browser.mjs';
 import { fakeOidc } from './helpers/fake-oidc.mjs';

packages/webui/tests/library-cli.test.mjs

@@ -14,7 +14,7 @@ test('C2-04 CLI: both listener callback pairs dispatch library verbs with their
   // The loader supplies a fixture bus and captures callbacks instead of
   // opening an HTTP listener. Production imports and routes are unchanged.
   const serveSource = "export const DEFAULT_BOARD='http://127.0.0.1:9';export const previewOptions=()=>null;export const proofOptions=()=>null;export async function startServer(o){if(typeof o.libraryFile!=='function'||typeof o.libraryStatus!=='function')throw Error('missing library callbacks');await o.libraryFile({project:'books',path:'Book One/A.md'});await o.libraryStatus({project:'books'});return {address:()=>({port:0}),close:()=>{}};}";
-  const busSource = `import {appendFileSync} from 'node:fs';export class BusReadError extends Error{};export const busCaller=o=>async(verb,args)=>{appendFileSync(${JSON.stringify(log)},JSON.stringify({verb,args,cli:o.cli??${JSON.stringify(HUMAN_CLI)}})+'\\n');return {};};`;
+  const busSource = `import {appendFileSync} from 'node:fs';export class BusReadError extends Error{};export const busCaller=o=>async(verb,args)=>{appendFileSync(${JSON.stringify(log)},JSON.stringify({verb,args,cli:o.cli??${JSON.stringify(HUMAN_CLI)}})+'\\n');return {};};export const busBusiness=()=>{throw Error('busBusiness outside --sso')};export const userCaller=()=>{throw Error('userCaller outside --sso')};`;
   writeFileSync(hook, `import {registerHooks} from 'node:module';
     registerHooks({load(url,context,next){
       if(url.endsWith('/webui/src/serve.mjs'))return {format:'module',shortCircuit:true,source:${JSON.stringify(serveSource)}};

packages/webui/tests/thread-claims.test.mjs

@@ -55,7 +55,7 @@ test('row278 Console adapter calls argument-free thread.claims through the norma
   const root = tmp(t, 'claims-cli-'), f = fixture(root), log = join(root, 'calls.jsonl'), hook = join(root, 'hooks.mjs');
   writeFileSync(log, '');
   const serveSource = `export const DEFAULT_BOARD='http://127.0.0.1:9';export const previewOptions=()=>null;export const proofOptions=()=>null;export async function startServer(o){await o.bus['thread.claims']();return {address:()=>({port:0}),close:()=>{}};}`;
-  const busSource = `import {appendFileSync} from 'node:fs';export class BusReadError extends Error{};export const busCaller=o=>async(verb,...args)=>{appendFileSync(${JSON.stringify(log)},JSON.stringify({verb,args,tester:!!o.cli})+'\\n');return [];};`;
+  const busSource = `import {appendFileSync} from 'node:fs';export class BusReadError extends Error{};export const busCaller=o=>async(verb,...args)=>{appendFileSync(${JSON.stringify(log)},JSON.stringify({verb,args,tester:!!o.cli})+'\\n');return [];};export const busBusiness=()=>{throw Error('busBusiness outside --sso')};export const userCaller=()=>{throw Error('userCaller outside --sso')};`;
   writeFileSync(hook, `import {registerHooks} from 'node:module';registerHooks({load(url,context,next){
     if(url.endsWith('/webui/src/serve.mjs'))return {format:'module',shortCircuit:true,source:${JSON.stringify(serveSource)}};
     if(url.endsWith('/webui/src/bus.mjs'))return {format:'module',shortCircuit:true,source:${JSON.stringify(busSource)}};